Allow OOM testing code to be used in non-debug builds

RESOLVED FIXED in Firefox 31

Status

()

Core
JavaScript Engine
--
critical
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: decoder, Assigned: decoder)

Tracking

(Blocks: 1 bug, {sec-want})

Trunk
mozilla31
x86_64
Linux
sec-want
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox31 fixed)

Details

(Whiteboard: [qa-][adv-main31-])

Attachments

(1 attachment)

(Assignee)

Description

3 years ago
Created attachment 8396839 [details] [diff] [review]
js-oom-opt.patch

In bug 964803, we added the --enable-oom-breakpoint flag, which we can now use to also enable the oomAfterAllocations functionality in --disable-debug builds. Patch attached.
Attachment #8396839 - Flags: review?(jdemooij)
Comment on attachment 8396839 [details] [diff] [review]
js-oom-opt.patch

Review of attachment 8396839 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good.

::: js/public/Utility.h
@@ +61,5 @@
>   */
>  #if defined JS_USE_CUSTOM_ALLOCATOR
>  # include "jscustomallocator.h"
>  #else
> +# if defined(JS_DEBUG) || defined(JS_OOM_BREAKPOINT)

Nit: please use DEBUG instead of JS_DEBUG, here and in the other files. We use JS_DEBUG in a few places, but DEBUG has many more hits so it's good to be consistent :)
Attachment #8396839 - Flags: review?(jdemooij) → review+
(Assignee)

Comment 2

3 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/8d521eaf9b65
Status: NEW → ASSIGNED
https://hg.mozilla.org/mozilla-central/rev/8d521eaf9b65
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla31
status-firefox31: --- → fixed
Whiteboard: [qa-]
Whiteboard: [qa-] → [qa-][adv-main31-]
You need to log in before you can comment on or make changes to this bug.