988108 - [camera][madai] capitalization corrections

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Camera, defect)

Description

[Tiffanie Shakespeare [:tif]]

Applies to menu when toggling menu items.

Menu item options should be sentence case:
- "On" or "Off"
- x seconds e.g. "5 seconds"

Grid should actually be Frame Grid

Comment 1

[Tiffanie Shakespeare [:tif]]

correction - ideally we could use "Grid Lines" as that is more clear. 

However, since the spec states "Frame Grid" that would be fine as well.

Comment 2

[Wilson Page [:wilsonpage]]

Attachment: pull-request (master)

Comment 3

[Tiffanie Shakespeare [:tif]]

Comment on attachment 8400637 [details] [review]
pull-request (master)

Everything looks awesome Wilson and thanks for fixing Grid Lines.

I'm giving a ui-review minus b/c the Off option under Self-Timer was missed. Fix that and we are all good! :)

Thanks Wilson!

Comment 4

[Tiffanie Shakespeare [:tif]]

Comment on attachment 8400637 [details] [review]
pull-request (master)

\w/

Comment 5

[Amy Lee [:amylee] UX]

Comment on attachment 8400637 [details] [review]
pull-request (master)

Looks good!

Comment 6

[Wilson Page [:wilsonpage]]

Landed on 'master': https://github.com/mozilla-b2g/gaia/commit/f64a5aec7d8138d85de6862b8c6b999abc55acca

Comment 7

[Francesco Lodolo [:flod]]

As I've already explained at least twice, you can't change strings after they landed on master
https://developer.mozilla.org/en-US/docs/Making_String_Changes

Please keep this in mind, and share this especially with people in charge of reviewing patches. 

From now on I'm going to file follow-up bugs to request new string IDs, and that's going to waste everyone's time, so please let's try to avoid it.

Comment 8

[David Flanagan [:djf]]

Bulk edit for camera bugs.

If earlier comments do not show how this bug landed to master, it probably landed as part of https://github.com/mozilla-b2g/gaia/pull/17599 which merged the camera-new-features branch into master.

This bug was uplifted from master to v1.4 as part of https://github.com/mozilla-b2g/gaia/commit/a8190d08e61316a86bba572ba8d894d081a20530