988148 - [Tarako][Lockscreen] there is no information displayed on SIM2 if card 2 is under limited service.

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::System::Lockscreen, defect)

Description

[shawn ku [:sku]]

Attachment: 2012-01-01-00-05-53.png

Precondition: 
1. two expired SIM (Emergency calls only)
2. set outgoing call to "SIM1"

STR:
1. reboot to Home
2. screen off -> screen on

Symptom:
SIM1 Emergency calls only
SIM2

Expected behavior:
SIM1 Emergency calls only
SIM2 Emergency calls only

Comment 1

[shawn ku [:sku]]

Attachment: 988148.log

Comment 2

[shawn ku [:sku]]

if we switch primary SIM to SIM2.
the issue symptom will become:

SIM1
SIM2 Emergency calls only

Comment 3

[shawn ku [:sku]]

Hi Arthur:
 Per offline chat, please help check this issue.
Thanks!!
Shawn

Comment 4

[Arthur Chen [:arthurcc][inactive after 6/30]]

Based on the spec, if two expired sim cards are equipped, we display only one "emergency calls only" on the screen.

Comment 5

[Arthur Chen [:arthurcc][inactive after 6/30]]

Attachment: Link to https://github.com/mozilla-b2g/gaia/pull/17628

Alive, could you help review the patch? The patch hides the mobile connection state if the corresponding sim is emergency calls only but not the primary sim. Also fixed a typo. Thanks.

Comment 6

[Arthur Chen [:arthurcc][inactive after 6/30]]

Nominate for 1.3T+ as the UI is confusing.

Comment 7

[Joe Cheng [:jcheng] (please needinfo)]

ni? Carrie to clarify expected behavior

Comment 8

[Joe Cheng [:jcheng] (please needinfo)]

back to 1.3T?

Comment 9

[Carrie Wang [New account: [e-mail]]]

Attachment: [SPEC] DSDS v0.8 .pdf

Hey guys, 
Please refer to p.7 Screen 1.
It does illustrate this use case. Thanks!

Comment 10

[Carrie Wang [New account: [e-mail]]]

I just had a discussion with Arthur. Please ignore comment 9.
The correct behavior should be:

1. Both SIM expired
"Emergency calls only"

2. If SIM 1 is the primary SIM and it works but SIM 2 is expired,
Only shows 
"SIM 1 #carrier name"
Since SIM 2 is not the primary SIM for outgoing calls and also not working, it will not display here.

3. If SIM 1 is the primary SIM and it is expired but SIM 2 is not,
"SIM 1 Emergency calls only"
"SIM 2 #carrier name"

Thanks!

Comment 11

[Arthur Chen [:arthurcc][inactive after 6/30]]

Comment on attachment 8396963 [details]
Link to https://github.com/mozilla-b2g/gaia/pull/17628

Clear the review request for a missing case.

Comment 12

[Arthur Chen [:arthurcc][inactive after 6/30]]

Comment on attachment 8396963 [details]
Link to https://github.com/mozilla-b2g/gaia/pull/17628

Patch updated and unit tests added. Alive, could you help review it? Thanks.

Comment 13

[Arthur Chen [:arthurcc][inactive after 6/30]]

master: 18f3cde260671a1f5d8d62e57caa5b6c39ce4d4d

Comment 14

[Joe Cheng [:jcheng] (please needinfo)]

this is a common bug for all DSDS devices
i'd like to have it fixed in all affected branches since it is an obvious display bug right on the lockscreen (we have Flame using 1.3)

asking 1.3 approval from Fabrice

Comment 15

[Joe Cheng [:jcheng] (please needinfo)]

Ying, can you uplift this for Tarako? Thanks

Comment 16

[ying.xu]

(In reply to Joe Cheng [:jcheng] from comment #15)
> Ying, can you uplift this for Tarako? Thanks

Steven Yang told me it will require level2 rights to push code into 1.3t while I'm at level1.

Comment 17

[ying.xu]

I will try this .

It's at github ,not hg.

Comment 18

[[:fabrice] Fabrice Desré]

(In reply to ying.xu from comment #17)
> I will try this .
> 
> It's at github ,not hg.

You won't have to, since we will land on 1.3 that is merged to 1.3t.

Comment 19

[Ryan VanderMeulen [:RyanVM]]

v1.4: https://github.com/mozilla-b2g/gaia/commit/74a5f4c42b8f6691c3f341ae37e6d67ef8e99de1
v1.3: https://github.com/mozilla-b2g/gaia/commit/523196662f4d19c7898d5f4773da020c39cfe57e