98821 - PAC: [e-mail]'s file [SOCKS]

Status: VERIFIED WORKSFORME

(Core :: Networking, defect)

Description

[s.wong]

From Bugzilla Helper:
User-Agent: Mozilla/4.77 [en] (X11; U; Linux 2.2.19 i686)
BuildID:    2001080104

Mozilla 0.9.3 does not work with the PAC from the specified link. "Document
Done" is displayed immediately at the bottom bar, without loading anything.

Reproducible: Always
Steps to Reproduce:
1. Put http://www.ec.auckland.ac.nz/proxy.pac in the Automatic proxy
configuration.
2. Load any page.
3. The automatic proxy page is accessible only if you are already running a
network authorisation program called "netaccount". Therefore, it would not be
reproducible outside the my university.

Here's the PAC:

/*
 * This proxypac was brought to you by...
 *
 *                           ** P A C M A N **
 *
 *           **************                        ****************
 *      ************************               ************************
 *   ******************************          ****************************
 *  ********************************        *******     ******     *******
 * ****************************             ********     ******     ******
 * **********************                   *******     ******     *******
 * ****************                         ******************************
 * **********************                   ******************************
 * ****************************             ******************************
 *  ********************************        ******************************
 *   ******************************         ******************************
 *      ************************             ********  ********  ********
 *           **************                    ****      ****      ****
 *
 *                              Computer Science Dept. Auckland University
 */
 
function FindProxyForURL( url, host )
{
        /* uni.proxy.pac */
 
        if( url.indexOf( "www.pgsa.auckland.ac.nz" ) > -1 )
        {
                return "SOCKS gate.ec.auckland.ac.nz:1080";
        }
 
        if( url.indexOf( "burrowes.org" ) > -1
                || url.indexOf( "cecil.edu" ) > -1
                || url.indexOf( "auckland.ac.nz" ) > -1
                || url.indexOf( "hmu.com" ) > -1 )
        {
                return "DIRECT";
        }
        if( isPlainHostName( host )
                || host.substring( 0, 8 ) == "130.216."
                || host == "127.0.0.1" )
        {
                return "DIRECT";
        }
        if( url.indexOf( "winz.govt.nz" ) > -1 )
        {
        {
                return "SOCKS gate.ec.auckland.ac.nz:1084";
        }
        else if( url.indexOf( "http://" ) > -1 )
        {
                return "PROXY gate.ec.auckland.ac.nz:8008";
        } else {
                return "SOCKS gate.ec.auckland.ac.nz:1080";
        }
}

Comment 1

[Chase Tingley]

Looking through the PAC, the most likely problem is that mozilla doesn't support
the SOCKS keyword properly yet.  SOCKS is supported, but only through manual
config -- the return value from a PAC file isn't handled properly.  This is
hopefully soon to change. 

Comment 2

[Chase Tingley]

there's a tentative dependency on bug 78176, since support for version-specific
SOCKS values in PAC would preusmably fix basic support as well.

Comment 3

[neeti]

pac

Comment 4

[benc]

We need a new bug on this. For one thing, I need a bug number for my functional
test results: bug 105335.

Comment 5

[basic]

reporter: do you build mozilla? If you do could you try applying the last patch
listed in bug 105335 ?

tingley: think you might be able to help the reporter with getting the
patch/hack into his build?

Comment 6

[basic]

Reporter: do you have a recent build?

Comment 7

[basic]

Reporter: do you have a recent build? If you do, could you use the component I'm
about to attach and test if it works now? Please put it in the components directory.

Comment 8

[basic]

Attachment: PAC component (nsProxyAutoConfig.js)

Comment 9

[basic]

this doesn't depend on bug 78176

Comment 10

[s.wong]

I didn't build mozilla myself. I'm still using 0.9.4, though getting 0.9.5 won't
be a problem. Will the patch make into the main tree so I can test it with a
nightly built? Or do I have to get the mozilla source, patch and compile?

Comment 11

[basic]

reporter: hmm... I must have missed your last post. Try downloading attachment
55173 [details] and save it as nsProxyAutoConfig.js in the components sub-directory in
your mozilla directory. You might also want to backup the nsProxyAutoConfig.js
that is already there just in case.

Comment 12

[basic]

I forgot to mention that you can put it in any recent mozilla build
(mozilla0.9.5 should work) and restart mozilla after replacing the file.

Comment 13

[s.wong]

With attachment 55173 [details] installed, I got the error message "The connection was
refused when attempting to contact bugzilla.mozilla.org." when assessing this
page. (The original nsProxyAutoConfig.js just returns without doing anything). I
tried the file with the linux 0.96 build.

Comment 14

[basic]

Attachment: nsProxyAutoConfig.js (lets try this again shall we?)

Made a really stupid mistake. Could you try this attachment? Thanks!

Comment 15

[s.wong]

Attachment 60127 [details] gives the same behaviour as the one comes with 0.96, ie mozilla
returns "document:done" without loading any pages.

Comment 16

[basic]

is this for SOCKS proxy alone or for all proxies?

Comment 17

[s.wong]

The university has 2 proxies. One is SOCKS with the automatic proxy
configuration (PAC?). The other is http with the manual configuration. Mozilla
has always work with the manual one, but never with the PAC. So the problem is
with the SOCKS with PAC.

Comment 18

[basic]

is the PAC file still the same as above?

Comment 19

[s.wong]

yes

Comment 20

[basic]

do you see anything displayed in the javascript console that might be related to
this?


from the above PAC there is one part that don't look quite right:

 if( url.indexOf( "winz.govt.nz" ) > -1 )
        {
        {
                return "SOCKS gate.ec.auckland.ac.nz:1084";
        }

Comment 21

[basic]

Do you get something like this in the javascript console?

Error: syntax error
Source File: http://www.ec.auckland.ac.nz/proxy.pac
Line: 260, Column: 8
Source Code:
        else if( url.indexOf( "http://" ) > -1 )

Comment 22

[s.wong]

Nothing shows up in the javascript console. Do I have to do anything
to make it show messages?

Anyway, I've done a more thorough testing of the new nsProxyScript.js.

1. From the list of url on the PAC file, it loads the following fine
     www.pgsa.auckland.ac.nz
     www.burrowes.org
     www.cecil.edu
     www.auckland.ac.nz (and all the subaddresses)
     www.hmu.com

2. www.winz.govt.nz gives "The connection was refused when attempting to
contact www.winz.govt.nz"

3. With anything else mozilla loads nothing. 

4. However, mozilla loads both of the 2 secure sites I've tried -
   https://mail.zfree.co.nz/
   https://www.nbnz.co.nz

Comment 23

[s.wong]

Attachment: Updated PAC.

Seems like the PAC I posted when originally report this bug somehow got an
extra { under the line with winz.govt.nz

Comment 24

[s.wong]

I've reloaded the original nsProxyAutoConfig.js and tested it with the same list
of urls I used with the new one. Other than the one mark as DIRECT in PAC,
nothing loads (including the https ones I tested).

It seems with the new script, the SOCKS thing is half working: the first "if"
with "SOCKS gate.ec.auckland.ac.nz:1080" works, but none of the other afterwards.

Comment 25

[basic]

okay from your tests:

this part works
>        if( url.indexOf( "www.pgsa.auckland.ac.nz" ) > -1 )
>        {
>                return "SOCKS gate.ec.auckland.ac.nz:1080";
>        }

this part works too
>        if( url.indexOf( "burrowes.org" ) > -1
>                || url.indexOf( "cecil.edu" ) > -1
>                || url.indexOf( "auckland.ac.nz" ) > -1
>                || url.indexOf( "hmu.com" ) > -1 )
>        {
>                return "DIRECT";
>        }

this part was not tested (but I doubt it should have any problems:
>        if( isPlainHostName( host )
>                || host.substring( 0, 8 ) == "130.216."
>                || host == "127.0.0.1" )
>        {
>                return "DIRECT";
>        }

this part does not work:
>        if( url.indexOf( "winz.govt.nz" ) > -1 )
>        {
>                return "SOCKS gate.ec.auckland.ac.nz:1084";
>        }

and this part does not work also:
>        else if( url.indexOf( "http://" ) > -1 )
>        {
>                return "PROXY gate.ec.auckland.ac.nz:8008";

this part does works!! (why? secure sites https:// ):
>        } else {
>                return "SOCKS gate.ec.auckland.ac.nz:1080";
>        }

could you try visiting winz.govt.nz with manual proxy setting:

SOCKS host: gate.ec.auckland.ac.nz 
port number: 1084
SOCKS v4

and www.mozilla.org with manual proxy setting:

HTTP proxy gate.ec.auckland.ac.nz
port number: 8008

Comment 26

[s.wong]

1. SOCKS host: gate.ec.auckland.ac.nz 
   port number: 1080
   SOCKS v4
   connection refused with www.pgsa.auckland.ac.nz (but works with PAC, wierd)

2. SOCKS host: gate.ec.auckland.ac.nz 
   port number: 1084
   SOCKS v4
   connection refused with www.winz.govt.nz

3. HTTP proxy gate.ec.auckland.ac.nz
   port number: 8008
   nothing is loaded with www.mozilla.org

Comment 27

[basic]

[e-mail]: you mentioned that there is a manual http proxy setting
that can be used, is that setting the same as:

HTTP proxy gate.ec.auckland.ac.nz
port number: 8008

As for these 2:

1. SOCKS host: gate.ec.auckland.ac.nz 
   port number: 1080
   SOCKS v4
   connection refused with www.pgsa.auckland.ac.nz (but works with PAC, wierd)

2. SOCKS host: gate.ec.auckland.ac.nz 
   port number: 1084
   SOCKS v4
   connection refused with www.winz.govt.nz

Did you test with the manual http proxy setting set or without (should be tested
without)?

Can you test the PAC with NN4 ?

Comment 28

[s.wong]

The manual http proxy is www-proxy.auckland.ac.nz:8080. It's for staff only.
Everyone else have to use the PAC.

> Did you test with the manual http proxy setting set or without (should be 
> tested without)?
It's tested without. The only field present is the SOCKS one.

> HTTP proxy gate.ec.auckland.ac.nz
> port number: 8008
This doesn't work anyway. I tested it with the HTTP field as the only one filled
in as well.

> Can you test the PAC with NN4 ?
I assume you mean netscape 4. It works the PAC. It's one of the supported
browsers here. Actually netscape 3 works as well, but I gather that it share the
codebase with version 4 anyway.

Comment 29

[basic]

looks like we might need some packet captures.

tingley: is there a chance that the networking code is refusing to connect to
some port numbers?

Comment 30

[Chase Tingley]

1080 (SOCKS) is the only one of these ports that appears on the blocked port
list, but that shouldn't be preventing the use of SOCKS outright (if it is, it
would be a bug, but socks support would also be totally broken for almost everyone).
If this were the case, adding 
 user_pref("network.security.ports.banned.override", "1080")
would fix the problem, but again this shouldn't be necessary.

I've verified that the PAC is fine, but haven't done much beyond that.

Comment 31

[basic]

I'm starting to think that the remaining problems here has nothing to do with
PAC, after the patch in 105335 lands on the trunk someone familiar with proxies
might need to take a look.

[e-mail] : any chance of getting a packet capture ?

Comment 32

[serge (gone)]

to default owner

Comment 33

[s.wong]

The pac is now working perfectly with 0.9.9.

Comment 34

[benc]

REOPEN...

Comment 35

[benc]

to RESOLVED: WFM (per reporter comments).

When I verify bug 105335, I'll verify this as well.

Comment 36

[s.wong]

Attachment: new pac file

This is the new PAC use in the university. It's just for your information as it
looks like that you're going to verify the bug. It looks to me not that
different from the old one, and shouldn't be the reason why mozilla started
working. The only real difference is a plain return is used at the end of the
file, instead of a else.

Comment 37

[benc]

So both worked in Comm 4, but only the new one worked in Mozilla?

I'll look at the two files and figure out if there is some syntactical aspect of
this we don't understand.

Comment 38

[benc]

VERIFIED:
SOCKS directive works now, so this file should work.

If a new file breaks, please file new bug for the file.