988243 - Multiple contact delete does not work with Facebook Contacts

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Contacts, defect)

Description

[Jose Manuel Cantera]

Multiple contact delete does not work with FB Contacts. We need to query the contact data before removing, in order to know it is a FB contact or not.

Comment 1

[Noemí Freire (:noemi)]

Pending functionality that needs to be addressed so nominating to 1.5?. Thanks!

Comment 2

[ashayb2g]

Hi Jose,

I have already considered deleting facebook contacts in multiple contact delete.
Can you please share a scenario where its not working?

Regards
Ashay

Comment 3

[Jose Manuel Cantera]

(In reply to ashayb2g from comment #2)
> Hi Jose,
> 
> I have already considered deleting facebook contacts in multiple contact
> delete.
> Can you please share a scenario where its not working?
> 
> Regards
> Ashay

You are only deleting the local contact but not the FB Contact in the datastore. I will fix that

Comment 4

[Joe Cheng [:jcheng] (please needinfo)]

1.5+ to make sure it is fixed as part of the multiple contacts delete new feature

Comment 5

[Jose Manuel Cantera]

Attachment: 17703.html

Comment 6

[Francisco Jordano [:arcturus] [:francisco]]

Comment on attachment 8397753 [details]
17703.html

Nice, this is the best solution and cleaner.

Tried and working well, thanks Jose, please merge once travis is green.

Thanks!

Comment 7

[Jose Manuel Cantera]

landed in master: 

https://github.com/mozilla-b2g/gaia/commit/ebf839cbdd80de887b92a3d38b0dfd10d4b74608

Comment 8

[Martin Shuman [:Marty]]

Verifying Fixed.  Issue no longer occurs in Flame 2.0
Multiple Facebook contacts are able to be deleted properly.

Environmental Variables:
Device: Flame 2.0
BuildID: 20140912000202
Gaia: 91dd0e596aa7c124dd968e1474b23e7992dc35a1
Gecko: a66168598533
Version: 32.0 (2.0)
Firmware: V123
User Agent: Mozilla/5.0 (Mobile; rv:32.0) Gecko/32.0 Firefox/32.0