988259 - [TestAgent] The "small screen" css is broken

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::TestAgent, defect)

Description

[Julien Wajsberg [:julienw]]

STR:
* run "bin/gaia-test -d"

Comment 1

[Ricky Chien [:rickychien] (inactive)]

Attachment: CSS render different.png

As you can see in attachment. I found the results are different between b2g-desktop and nightly. Compare these two results in screenshot, there exist several differences in details. I think no matter on b2g or on nightly we should have same rendering result. Maybe it is a CSS bug on b2g?

Comment 2

[Julien Wajsberg [:julienw]]

I don't know why there could be a difference... 
In my nightly, the "Enable coverage" box is overriding the "#communications" title too.

I think all this happens because we're using "position: absolute" and margin-top or things like this, can't we just use the normal flow?

Comment 3

[Ricky Chien [:rickychien] (inactive)]

I'm sure there exist some different on b2g so that certain CSS effect doesn't work. But I think I can take this and find a workaround for nightly.

Comment 4

[Ricky Chien [:rickychien] (inactive)]

Attachment: Gaia PR

Comment 5

[Ricky Chien [:rickychien] (inactive)]

Attachment: Js-test-agent PR

Comment 6

[Ricky Chien [:rickychien] (inactive)]

@Julien, could you help me review this CSS bug? 

I've fixed broken layout in small screen (320x480) on nightly. Just copy test-agent.css from my patch and resize in any size you want. Thanks :)

Comment 7

[Julien Wajsberg [:julienw]]

Comment on attachment 8415058 [details] [review]
Gaia PR

r=me with more opacity in the header's background

Comment 8

[Julien Wajsberg [:julienw]]

Comment on attachment 8415060 [details] [review]
Js-test-agent PR

same

please do what's necessary to land it as I don't know these days ;)

Comment 9

[Ricky Chien [:rickychien] (inactive)]

Attachment: Gaia-node-modules PR

We also need to update gaia-node-modules for "make update-common"

Comment 10

[Ricky Chien [:rickychien] (inactive)]

Attachment: Gaia PR - update node_modules revision

Comment 11

[Ricky Chien [:rickychien] (inactive)]

Merged.

https://github.com/mozilla-b2g/gaia/commit/fd73c3c2bb5f587f8fb04c3236cf7bf1ccdedd6b
https://github.com/mozilla-b2g/js-test-agent/commit/06df11327625b160ea80eb89f4e9915acc1e63e2
https://github.com/mozilla-b2g/gaia-node-modules/commit/3974884c2915d3b7feac9fbe653f83c23dfb423a

Follow-up PR for updating gaia_node_modules.revision
https://github.com/mozilla-b2g/gaia/commit/cf285caa0c65244abae9fc99cc6f88765a8d8737