Closed
Bug 988278
Opened 11 years ago
Closed 10 years ago
DevTools: Inspector: First ESC after cmd+opt+c shortcut should cancel element picking, second ESC should open split console
Categories
(DevTools :: Inspector, defect, P1)
Tracking
(firefox40 fixed)
RESOLVED
FIXED
Firefox 40
Tracking | Status | |
---|---|---|
firefox40 | --- | fixed |
People
(Reporter: thomas, Assigned: pbro)
References
(Blocks 1 open bug)
Details
(Whiteboard: [polish-backlog][difficulty=easy])
Attachments
(1 file, 1 obsolete file)
User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.9; rv:28.0) Gecko/20100101 Firefox/28.0 (Beta/Release) Build ID: 20140314220517 Steps to reproduce: 1. Open the Inspector 2. Press escape Actual results: Nothing Expected results: Like the other panels, the split console is opened when the escape key is pressed after directly opening the panel from the menu item / keyboard shortcut. When the Inspector panel is directly opened the user has to 1. focus the the panel and 2. press escape twice before the split console is opened.
Reporter | ||
Comment 1•11 years ago
|
||
This is in nightly btw. Works as expected in version 28 (ref. user-agent info in initial comment)
Updated•11 years ago
|
Component: Developer Tools → Developer Tools: Inspector
Comment 2•11 years ago
|
||
I've checked by opening inspector with keyboard shortcut and by right click -> Inspect element, and in both cases the split console seems to open on the first Escape keypress with no extra actions needed. Do you have any more info to reproduce?
Reporter | ||
Comment 3•11 years ago
|
||
Using nightly 31.0a1 (2014-03-24) (OS-X) 1. Start the browser 2. From any webpage, press Alt+Cmd+C 3. Press the escape key Result: split console is not opened. 4. Focus the panel. Eg. click/select on the body tag in the tree 5. Press the escape key 6. Press the escape key Result: split console always opens the second time the escape key is pressed. If I change #2 to be eg. Network monitor (Alt+Cmd+Q), the escape key opens the split console on the first escape key press. Same with Debugger and Style Editor etc. It does not matter if I am using a clean profile or not. hm, it is probably not related but when I update the 31.0a1 (2014-03-24) nightly build from the About dialog it always stays on 31.0a1 (2014-03-24). I can try to delete my nightly and download it from scratch.
Reporter | ||
Comment 4•11 years ago
|
||
Same result with nightly 31.0a1 (2014-03-27).
Comment 5•11 years ago
|
||
(In reply to Thomas Andersen from comment #3) > Using nightly 31.0a1 (2014-03-24) (OS-X) > > 1. Start the browser > 2. From any webpage, press Alt+Cmd+C > 3. Press the escape key > > Result: split console is not opened. > > 4. Focus the panel. Eg. click/select on the body tag in the tree > 5. Press the escape key > 6. Press the escape key > > Result: split console always opens the second time the escape key is pressed. > > If I change #2 to be eg. Network monitor (Alt+Cmd+Q), the escape key opens > the split console on the first escape key press. > Same with Debugger and Style Editor etc. > > It does not matter if I am using a clean profile or not. > > hm, it is probably not related but when I update the 31.0a1 (2014-03-24) > nightly build from the About dialog it always stays on 31.0a1 (2014-03-24). > > I can try to delete my nightly and download it from scratch. OK, so this is an issue when opening with cmd+opt+c (which opens inspector in the inspect element mode). The behavior I expect following these steps would be that the first escape cancels the element selection, and the second escape opens the split console on the inspector panel. So this is currently not working as expected.
Status: UNCONFIRMED → NEW
Ever confirmed: true
Updated•11 years ago
|
Blocks: DevToolsPaperCuts
Updated•11 years ago
|
Summary: DevTools: Inspector: Inconsistent split console behavior → DevTools: Inspector: Escape not opening split console after opening inspector with cmd+opt+c shortcut
Reporter | ||
Comment 6•11 years ago
|
||
Sorry if my explanation was convoluted or something.
> OK, so this is an issue when opening with cmd+opt+c
From further investigation, this happens when:
1. Cmd+Alt+C shortcut is used.
2. Tools -> Web Developer -> Inspector menu item is chosen.
This does is _not an issue if I context click an element and choose Inspect Element from the context menu.
Updated•10 years ago
|
Summary: DevTools: Inspector: Escape not opening split console after opening inspector with cmd+opt+c shortcut → DevTools: Inspector: Pressing ESC after cmd+opt+c shortcut should cancel element picking
Comment 7•10 years ago
|
||
This is an issue even if element picking is initialized after pressing the button in the UI. I believe this will be resolved by Bug 1120111.
See Also: → 1120111
Updated•10 years ago
|
Comment 8•10 years ago
|
||
Once the first ESC is cancels element picking, we need to make sure that the inspector is properly focused so that the second ESC opens the split console. This may actually work after 1120111, since cmd+opt+I seems to work as expected already, but we should double check once it lands.
Comment 9•10 years ago
|
||
I can reproduce the second part of this bug (after clearing the picking mode) with the following steps: Open the inspector on any page Click on an element in the markup view Press ESC (nothing happens) Press ESC a second time (split console opens) At this point it only takes a single ESC to toggle split console on/off, but the first time is a problem.
Comment 10•10 years ago
|
||
After 1120111 has landed, the first ESC now cancels element picking correctly, but the second one still doesn't open up the split console.
Updated•10 years ago
|
Whiteboard: [devedition-40]
Comment 11•10 years ago
|
||
Agreed - we need to both cancel the highlighter *and* set focus on the toolbox. The user is using a tool, if they cancel out of that by hitting escape focus should go back to the toolbox they launched the tool from.
Comment 12•10 years ago
|
||
Assigning P1 priority for some devedition-40 bugs. Filter on '148DD49E-D162-440B-AE28-E22632FC20AC'
Priority: -- → P1
Assignee | ||
Updated•10 years ago
|
Whiteboard: [devedition-40] → [devedition-40][difficulty=easy]
Assignee | ||
Comment 13•10 years ago
|
||
To sum up, there are 2 issues to fix: - When in pick mode, the first ESC cancels the selection (works today), but the second ESC should open the split console -> This doesn't work because the toolbox isn't focused. - When opening the inspector and clicking on a node in the tree, it takes 2 ESC to open the split console the first time.
Assignee: nobody → pbrosset
Status: NEW → ASSIGNED
Assignee | ||
Comment 14•10 years ago
|
||
/r/6867 - Bug 988278 - Fixes ESCape keypress mess in the inspector to make sure the split console opens; r=miker Pull down this commit: hg pull -r f9c3d39bc84ecdf43b2c07795e8330dce65a9656 https://reviewboard-hg.mozilla.org/gecko/
Attachment #8590843 -
Flags: review?(mratcliffe)
Comment 15•10 years ago
|
||
Comment on attachment 8590843 [details] MozReview Request: bz://988278/pbrosset https://reviewboard.mozilla.org/r/6865/#review5725 Ship It!
Attachment #8590843 -
Flags: review?(mratcliffe) → review+
Assignee | ||
Comment 16•10 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=fc52bc5d48c5
Assignee | ||
Comment 17•10 years ago
|
||
https://hg.mozilla.org/integration/fx-team/rev/67683aaa2041
https://hg.mozilla.org/mozilla-central/rev/67683aaa2041
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
status-firefox40:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 40
Assignee | ||
Comment 19•9 years ago
|
||
Attachment #8590843 -
Attachment is obsolete: true
Attachment #8618104 -
Flags: review+
Assignee | ||
Comment 20•9 years ago
|
||
Updated•9 years ago
|
Whiteboard: [devedition-40][difficulty=easy] → [polish-backlog][difficulty=easy]
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•