Closed
Bug 988389
Opened 11 years ago
Closed 11 years ago
Loop REST client helper
Categories
(Firefox OS Graveyard :: Gaia::Loop, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: ferjm, Assigned: ferjm)
References
Details
Attachments
(2 files, 1 obsolete file)
REST client helper to talk to the Loop server
|
Assignee | |
Updated•11 years ago
|
Summary: Loop client helper → Loop REST client helper
|
|
Assignee | |
Updated•11 years ago
|
Assignee: nobody → ferjmoreno
|
|
Assignee | |
Comment 1•11 years ago
|
||
Borja, I've created the basic app scaffolding containing the basic rest client helper and its corresponding tests. Since this code should end up landing in Gaia at some point post 1.5, the idea is to use Gaia's test mechanism for our own tests. The repo currently lives in my github account, but as soon as I get your r+ I'll ask github.com/mozilla-b2g owners to create a repo for this app.
Attachment #8398712 -
Flags: review?(borja.bugzilla)
|
|
Assignee | |
Updated•11 years ago
|
Attachment #8398712 -
Attachment is obsolete: true
Attachment #8398712 -
Flags: review?(borja.bugzilla)
|
|
Assignee | |
Comment 2•11 years ago
|
||
We have the mozilla-b2g repo now :)
Attachment #8398737 -
Flags: review?(borja.bugzilla)
|
||
Comment 3•11 years ago
|
||
Comment on attachment 8398737 [details] [review]
v1
Some comments added, but structure (and tests!) looks great to me. Address the suggestions and let me know to take the final review!
Attachment #8398737 -
Flags: review?(borja.bugzilla) → feedback+
|
|
||
Comment 4•11 years ago
|
||
Attachment #8400722 -
Flags: review?(josea.olivera)
|
||
Comment 5•11 years ago
|
||
Comment on attachment 8400722 [details] [review]
Patch rebased
LGTM and tests pass so please land it at will. r=me
Attachment #8400722 -
Flags: review?(josea.olivera) → review+
|
|
||
Updated•11 years ago
|
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•