Closed Bug 988389 Opened 9 years ago Closed 9 years ago

Loop REST client helper

Categories

(Firefox OS Graveyard :: Gaia::Loop, defect)

ARM
Gonk (Firefox OS)
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: ferjm, Assigned: ferjm)

References

Details

Attachments

(2 files, 1 obsolete file)

v1
59 bytes, text/x-github-pull-request
borjasalguero
: feedback+
Details | Review
59 bytes, text/x-github-pull-request
jaoo
: review+
Details | Review
REST client helper to talk to the Loop server
Summary: Loop client helper → Loop REST client helper
Assignee: nobody → ferjmoreno
Depends on: 988831
Attached file v1 (obsolete) —
Borja, I've created the basic app scaffolding containing the basic rest client helper and its corresponding tests. Since this code should end up landing in Gaia at some point post 1.5, the idea is to use Gaia's test mechanism for our own tests. The repo currently lives in my github account, but as soon as I get your r+ I'll ask github.com/mozilla-b2g owners to create a repo for this app.
Attachment #8398712 - Flags: review?(borja.bugzilla)
Attachment #8398712 - Attachment is obsolete: true
Attachment #8398712 - Flags: review?(borja.bugzilla)
Attached file v1
We have the mozilla-b2g repo now :)
Attachment #8398737 - Flags: review?(borja.bugzilla)
Comment on attachment 8398737 [details] [review]
v1

Some comments added, but structure (and tests!) looks great to me. Address the suggestions and let me know to take the final review!
Attachment #8398737 - Flags: review?(borja.bugzilla) → feedback+
Attached file Patch rebased
Attachment #8400722 - Flags: review?(josea.olivera)
Comment on attachment 8400722 [details] [review]
Patch rebased

LGTM and tests pass so please land it at will. r=me
Attachment #8400722 - Flags: review?(josea.olivera) → review+
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.