Closed Bug 988396 Opened 11 years ago Closed 11 years ago

URL generation flow

Categories

(Firefox OS Graveyard :: Gaia::Loop, defect)

Product:
Firefox OS Graveyard
Component:
Gaia::Loop
Platform:
ARM
Gonk (Firefox OS)
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: ferjm, Assigned: jaoo)

References

Details

Attachments

(2 files, 5 obsolete files)

Pointer to Github PR https://github.com/mozilla-b2g/firefoxos-loop-client/pull/6
59 bytes, text/x-github-pull-request
Details | Review
v5 r=ferjm
133.33 KB, patch
borjasalguero
: review+
Details | Diff | Splinter Review
No description provided.
Assignee: nobody → josea.olivera
Attached patch WIP (obsolete) — — Splinter Review
WIP patch. Working prototype. It still needs unit tests for the functions added to the new call helper object.
Attached patch v1 (obsolete) — — Splinter Review
v1 version of the work. Some tests added.
Attachment #8413800 - Attachment is obsolete: true
Attachment #8414458 - Flags: review?(ferjmoreno)
Comment on attachment 8414458 [details] [diff] [review] v1 Gave feedback offline. Basically we want to focus this bug in a simple URL generation flow without all the user registration and call screen bits that will be done in other bugs.
Attachment #8414458 - Flags: review?(ferjmoreno)
Attached patch v2 (obsolete) — — Splinter Review
PS. PR updated.
Attachment #8414458 - Attachment is obsolete: true
Attachment #8416669 - Flags: review?(ferjmoreno)
Comment on attachment 8416669 [details] [diff] [review] v2 Thanks jaoo! Looks great! I left a few comments on the PR. I'd like to see a final version of the patch and get also Borja's review :).
Attachment #8416669 - Flags: review?(ferjmoreno) → feedback+
Attached patch v3 (obsolete) — — Splinter Review
(In reply to Fernando Jiménez Moreno [:ferjm] from comment #6) > Comment on attachment 8416669 [details] [diff] [review] > v2 Thanks for the review. > Thanks jaoo! Looks great! I left a few comments on the PR. I'd like to see a > final version of the patch and get also Borja's review :). Comments addressed, would you mind to review them again please? Thanks! PS. PR updated.
Attachment #8416669 - Attachment is obsolete: true
Attachment #8417446 - Flags: review?(ferjmoreno)
Attachment #8417446 - Flags: review?(borja.bugzilla)
Blocks: 1007941
No longer blocks: Loopmov_1_1
Comment on attachment 8417446 [details] [diff] [review] v3 Some comments in Github. Please take a look and let me know when ready! Thanks!
Attachment #8417446 - Flags: review?(borja.bugzilla)
Attached patch v4 (obsolete) — — Splinter Review
Borja's comments addressed.
Attachment #8417446 - Attachment is obsolete: true
Attachment #8417446 - Flags: review?(ferjmoreno)
Attachment #8421331 - Flags: review?(ferjmoreno)
Attachment #8421331 - Flags: review?(borja.bugzilla)
Comment on attachment 8421331 [details] [diff] [review] v4 LGTM! Thanks jaoo! I've left a few final comments in the PR
Attachment #8421331 - Flags: review?(ferjmoreno) → review+
Attached patch v5 r=ferjm — — Splinter Review
ferjm's comments addressed Carrying out r=ferjm PS. PR updated
Attachment #8421331 - Attachment is obsolete: true
Attachment #8421331 - Flags: review?(borja.bugzilla)
Attachment #8421630 - Flags: review?(borja.bugzilla)
Comment on attachment 8421630 [details] [diff] [review] v5 r=ferjm Review of attachment 8421630 [details] [diff] [review]: ----------------------------------------------------------------- R+ from my side! Before merging please update the BB in order to avoid the ".svg". Thanks!
Attachment #8421630 - Flags: review?(borja.bugzilla) → review+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: