988430 - [B2G][Contacts] Cancelling on allow offline access page for importing Gmail contacts brings user to blank page

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Contacts, defect)

Description

[Brogan Zumwalt [Inactive]]

Attachment: Logcat

Description:
When user signs into Gmail account to import information to contacts app they are taken to a page asking to allow Gmail to have offline access. If user presses cancel on this screen they are taken to a blank white browser page. User is able to exit out of this page.

Repro Steps:
1) Updated Buri to BuildID: 20140326000201
2) Launch contacts app
3) Open settings menu by pressing gear icon
4) Select Import Contacts
5) Choose Gmail and log in with a valid email account
6) On screen asking you to allow offline access select cancel

Actual:
Selecting cancel on screen asking to allow offline access for Gmail brings user to blank page.

Expected:
Selecting cancel on screen asking to allow offline access for Gmail brings user back to import contacts screen.

Environmental Variables:
Device: Buri v1.4 Mozilla RIL
BuildID: 20140326000201
Gaia: 7e705dd4718d528974d99ac31866318d7e201152
Gecko: 4889124accfa
Version: 30.0a2
Firmware Version: v1.2-device.cfg

Notes:
Repro frequency: 3/3, 100%
See attached: Youtube video clip & logcat
Youtube link: http://youtu.be/m5iTDiK-X-I

Comment 1

[Jason Smith [:jsmith]]

Does this happen on 1.3?

Comment 2

[Ross Kuhlman ([e-mail])]

Issue also occurs in 1.3

Environmental Variables:
Device: Buri v1.3 Moz RIL
BuildID: 20140328004002
Gaia: 523196662f4d19c7898d5f4773da020c39cfe57e
Gecko: aa1d48ab3715
Version: 28.0
Firmware Version: v1.2-device.cfg

Comment 3

[Jason Smith [:jsmith]]

What about 1.1?

Comment 4

[sarsenyev]

It doesn't reproduce on 1.1 
On 1.1. no "Offline Confirmation" page appears the user is redirected to "Gmail Contacts" right after signed into account

1.1 Environmental Variables:
Device: Buri 1.1 MOZ
BuildID: 20140327041202
Gaia: 44a2ddf63373f8e95c784faf4ed4d60081699c61
Gecko: 24ed63715d1b
Version: 18.0
Firmware Version: v1.2-device.cfg

Comment 5

[Jason Smith [:jsmith]]

Francisco - Did we change something in how we import google contacts from 1.1 vs. 1.3? It seems we're getting an offline access prompt on 1.3, but not on 1.1. This is a problem on Google's side with the blank page, right (i.e. not a bug in Gaia or Gecko)?

Comment 6

[Francisco Jordano [:arcturus] [:francisco]]

Hi Jason,

yes, in v1.3 we have changed the way we do the logout. Now we do logout each time we import contacts not just from Gmail, also from Outlook.

That logout is done via querying a web page. I think that's the reason why it's failing.

For me it's not a blocker, but something that perhaps we will time to fix in a 1.4 or 1.5

Cheers,
F.

Comment 7

[Noemí Freire (:noemi)]

This data refactor tries to provide contacts with the hability to aggregate different contacts sources without having to integrate with the contacts app code

Comment 8

[Noemí Freire (:noemi)]

Please ignore comment 7 that is not related to this bug at all. Sorry for the inconvenience.

Comment 9

[Francisco Jordano [:arcturus] [:francisco]]

We are suffering from a 'please ignore my comment' plague.

Please ignore my comment 6, since this is another scenario.

Will check why we are not closing on callback for canceling.

Comment 10

[Francisco Jordano [:arcturus] [:francisco]]

Attachment: Pointer to PR 17824

1 line patch, 80 lines unit test :)

Comment 11

[Noemí Freire (:noemi)]

Hi,

This issue also occurs on v1.2:
Device: hamachi
BuildId: 20140326124525
Gaia: 539a25e
Gecko: c26907b
Platform version: 26.0

The thing is that in v1.3 is more visible since "grant permissions" window appears each time the user tries to import contacts ( see Bug 962377: https://bugzilla.mozilla.org/show_bug.cgi?id=962377#c22 for further details) not just the first time as it was in previous versions. We should try to fix it as soon as possible, because of this asking for v1.3?

Just to clarify the user's impact, once users are in the blank page, tapping on "x" backs them to import contacts screen and gmail import process can be initiated again

Comment 12

[Jose Manuel Cantera]

Comment on attachment 8399552 [details] [review]
Pointer to PR 17824

Tested it and works properly. 

I left some comments on GH, please check.

Comment 13

[Francisco Jordano [:arcturus] [:francisco]]

Landed in master:

https://github.com/mozilla-b2g/gaia/commit/c1f7ecfd61747592d6ead5ef72c8d1b21c1531d3