Closed Bug 988482 Opened 9 years ago Closed 9 years ago

Implement Linux styling of Translation Infobar


(Firefox :: Theme, defect)

Not set



Firefox 32


(Reporter: MarcoM, Assigned: mak, NeedInfo)


(Blocks 1 open bug)


(Whiteboard: [translation] p=3 s=it-32c-31a-30b.2 [qa-])


(1 file)

Implement Linux styling of translation infobar.
Depends on: 988479
No longer blocks: fxdesktopbacklog
Flags: firefox-backlog+
Whiteboard: [translation] p=0 → [translation] p=3
Assignee: nobody → mak77
Whiteboard: [translation] p=3 → [translation] p=3 s=it-32c-31a-30b.1 [qa?]
Component: General → Theme
Whiteboard: [translation] p=3 s=it-32c-31a-30b.1 [qa?] → [translation] p=3 s=it-32c-31a-30b.1 [qa-]
patch is in bug 988481.
Depends on: 988481
Whiteboard: [translation] p=3 s=it-32c-31a-30b.1 [qa-] → [translation] p=3 s=it-32c-31a-30b.2 [qa-]
Fixed by bug 988481.
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 32
Hi guys!

I landed here trying to make translation infobar looking good when the width is constrained (bug 1008224). Bug 1008214 provides a mock up [1] of the infobar at 564px. Trying to implement this I realized that translation infobar is implemented differently on different platforms. Since I am using linux I started there and could get the width of the infobar to approx. 680 px before it starts to overflow. Among reasons for this I believe is that the infobar controls are bigger than those used in the mockup. See the attachment for the screenshot made on ubuntu. Whatever platform that mockup was created for it seem to me that there is a mismatch between design and implementation at least on Ubuntu (linux). So before going further with bug 1008224 I would like to know if the screenshot that I attached looks as intended on linux?
Bug 979424 has a mockup attached [2] that displays how the translation infobars was expected to look initially regardless of platforms. Controls there are also pretty thin. During various stages of implementation however the final design drifted away from this mockups. For example this [3] is the final design for windows, which was copied to linux; and this [4] is osx. Note the different padding inside buttons and lists.

If the screenshot deviates from the intended design, should I reopen this bug and try to fit it? Should I open a new bug? Or should I submit a patch in bug 1008224 that makes buttons thinner only in constrained settings?

Sorry for stealing you time for such small things but I am kind of stuck and get further without the help from experienced mozillians. 

Flags: needinfo?(sfranks)
Flags: needinfo?(mak77)
I'm not following the translation bar project at the moment, and I don't want to give you outdated information, I'm forwarding your request to Florian, that I think is still somewhat focused on it.
The theming here was done based on UX requests made at that time, and what I see in the screenshot, afaict, is how things were intended to be one year ago. The bigger controls were requested explicitly at that time.
I think the question is more for UX than engineering, btw.
Flags: needinfo?(mak77) → needinfo?(florian)
Thanks for looking in to this, Iaroslav!

I'm going to switch the needinfo to Michael Maslaney who is much more familiar with visuals across OSes than I. I feel like the notification bar designs have been modified even further still since the translation project was live.

Mike, do you have an insight?
Flags: needinfo?(mmaslaney)
Flags: needinfo?(sfranks)
Flags: needinfo?(florian)
You need to log in before you can comment on or make changes to this bug.