988527 - End of progress bar is offset by 1px

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Brian Nicholson (:bnicholson)]

Attachment: screenshot.png

See screenshot.

GT-P1000N, Android 2.2.

Comment 1

[Mark Finkle (:mfinkle) (use needinfo?)]

Is this limited to the device and android 2.2?

Comment 2

[Brian Nicholson (:bnicholson)]

As far as I know. I haven't been able to reproduce on anything else (though I haven't tested many devices).

Comment 3

[Ioana Chiorean]

This is also present on HTC Desire S (Android 2.3.3) with the Tinderbox Beta build.  
http://ftp.mozilla.org/pub/mozilla.org/mobile/tinderbox-builds/mozilla-beta-android/1395862133/

Comment 4

[Aaron Train [:aaronmt]]

Don't see this on Android 4.3/4.4

Comment 5

[Brian Nicholson (:bnicholson)]

Attachment: Fix progress.9.png to have balanced padding

Looks like the problem here is bad assets: the extra space above and below the progress bars are not balanced. For example, in our MDPI image, the distance between the top of the image and the top of the progress bar is 9x; the distance between the bottom of the progress bar and the bottom of the image is 8px. When the image is scaled, this results in slightly more weight at the bottom of the image, causing the bulb to be misaligned.

To fix this, I just added an extra pixel to top left border of the 9png, which effectively subtracts 1px from the top non-stretchable padding area. This makes the bottom and top non-stretchable padding areas equal.

Comment 6

[Aaron Train [:aaronmt]]

Spotted on my Nexus S (2.3)

Comment 7

[Brian Nicholson (:bnicholson)]

Attachment: before/after images (10x scale)

Just to be clear what I'm referring to, here's a before/after of the MDPI image (at 10x scale). Similar changes needed to be made to the HDPI and XHDPI assets.

Comment 8

[Brian Nicholson (:bnicholson)]

Aaron, Can you confirm that this build works as expected on your Nexus S and other devices? http://people.mozilla.org/~bnicholson/fennec_builds/progress-bar-10.apk

Comment 9

[Aaron Train [:aaronmt]]

WFM

Comment 10

[Lucas Rocha (:lucasr)]

Comment on attachment 8398080 [details] [diff] [review]
Fix progress.9.png to have balanced padding

Review of attachment 8398080 [details] [diff] [review]:
-----------------------------------------------------------------

Nice catch.

Comment 11

[Brian Nicholson (:bnicholson)]

https://hg.mozilla.org/integration/fx-team/rev/194b624cdec5

Comment 12

[Brian Nicholson (:bnicholson)]

Comment on attachment 8398080 [details] [diff] [review]
Fix progress.9.png to have balanced padding

[Approval Request Comment]
Bug caused by (feature/regressing bug #): bug 962103
User impact if declined: progress bar tip is offset by 1px; see screenshot
Testing completed (on m-c, etc.): locally
Risk to taking this patch (and alternatives if risky): very low risk; only changes images, not code
String or IDL/UUID changes made by this patch: none

Comment 13

[Lukas Blakk [:lsblakk] use ?needinfo]

Triage drive by: we'll hold off on marking status fixed (and approving uplifts) until this lands on central without issue.

Comment 14

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/194b624cdec5

Comment 15

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/0cfd2404aa85
https://hg.mozilla.org/releases/mozilla-beta/rev/4a91de843cb7

Comment 16

[Catalin Suciu [:csuciu]]

Verified fixed on Aurora 30.0a2 (2014-04-02)

Still needs to be verified on Firefox 29 Beta 6

Comment 17

[Catalin Suciu [:csuciu]]

Verified fixed on Firefox 29 Beta 6