Closed Bug 988589 Opened 10 years ago Closed 10 years ago

Re-enable forgot password inputs in fxa system app

Categories

(Firefox OS Graveyard :: Gaia::System, defect)

Product:
Firefox OS Graveyard
Component:
Gaia::System
Platform:
x86
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(b2g-v2.0 fixed)

Status:
RESOLVED FIXED
Milestone:
2.0 S1 (9may)
Tracking Flags:
Tracking Status
b2g-v2.0 --- fixed

People

(Reporter: jhirsch, Assigned: jhirsch)

References

Details

Attachments

(1 file)

Github PR 17734
46 bytes, text/x-github-pull-request
alive
: review+
borjasalguero
: feedback+
Details | Review 
So far, this is all I've found--but there might be other stuff mismerged:

https://github.com/mozilla-b2g/gaia/commit/e5d3435#commitcomment-5811718
Assignee: nobody → 6a68
Blocks: 987416
Summary: Double-check 972645 commit wasn't overwritten by 897600 merge → Re-enable forgot password inputs in fxa system app
Attached file Github PR 17734 — 

        Attachment #8398248 -
        Flags: review?(borja.bugzilla)

    
    

    
  
I think I had the wrong reviewer, let's try one of the system owners...

    
    

    
  
Comment on attachment 8398248 [details] [review]
Github PR 17734

Hi Alive, this is a small change, do you have time to look at it? If not, could you suggest another reviewer?

        Attachment #8398248 -
        Flags: review?(borja.bugzilla) → review?(alive)
Flags: needinfo?(alive)

    
    

    
  
Comment on attachment 8398248 [details] [review]
Github PR 17734

Hi Borja, please give some feedback here.
My question: why javascript part doesn't control the class per current state?

        Attachment #8398248 -
        Flags: review?(alive)

        Attachment #8398248 -
        Flags: review+

        Attachment #8398248 -
        Flags: feedback?(borja.bugzilla)
Flags: needinfo?(alive)

    
    

    
  
Comment on attachment 8398248 [details] [review]
Github PR 17734

Hi Alive,
In this case was an error while merging. There is no need to disable this button right now, due to we have the mechanism to 'reset' your password. That's why the change, and why we have no JS logic behind.

Travis now is green, so Jared, I think you are ready to merge!

        Attachment #8398248 -
        Flags: feedback?(borja.bugzilla) → feedback+

    
    

    
  
Alive, Borja, thanks so much for the review! Merging now.

    
    

    
  
Master: https://github.com/mozilla-b2g/gaia/commit/e8d38c0bdf66136004636305b05aeeec36be758b
Status: NEW → RESOLVED
Closed: 10 years ago

          status-b2g-v2.0:
          --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 1.5 S1 (9may)

    
    

    
  
RyanVM - does the merge comment and flag-setting in comment 7 look correct? Thanks!
Flags: needinfo?(ryanvm)

    
    

    
  
Looks fine, thanks.
Flags: needinfo?(ryanvm)

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: