988632 - [Camera][Madai] More frequent instances of "Picture not saved" when tapping shutter button

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Camera, defect)

Description

[Marcia Knous [:marcia]]

Buri, while running with the latest master.

Gaia   5ae2df02e30bda2ae04830d6e181ecf31ff38817
SourceStamp c69c55582faa
BuildID 20140326040202
Version 31.0a1

STR:

1. Take a rapid succession of pictures with the camera.
2. Observe the attached screenshot

Comment 1

[Marcia Knous [:marcia]]

Attachment: Screenshot of issue on Buri

Comment 2

[Marcia Knous [:marcia]]

Attachment: Logcat while hitting shutter button rapidly

Here is the logcat while rapidly tapping the shutter button.

Comment 3

[Jason Smith [:jsmith]]

Can we confirm we can't reproduce this on 1.4 with the old camera implementation?

Comment 4

[Mike Habicher [:mikeh] (high bugzilla latency)]

Looking at the logcat, I see several occurrences of:

E/GeckoConsole(  514): [JavaScript Error: "NS_ERROR_FAILURE: " {file: "app://camera.gaiamobile.org/js/main.js" line: 3960}]

Comment 5

[Justin D'Arcangelo [:justindarc]]

I'm able to reproduce this on 1.4 with the old Camera as well. Looking into the JS error that Mike mentioned now.

Comment 6

[Justin D'Arcangelo [:justindarc]]

Confirmed with Mike that the JS error in the logcat is thrown when `takePicture()` is called while another `takePicture()` is already in progress.

Comment 7

[Jason Smith [:jsmith]]

Okay - leaving qawanted to see if this happens on 1.3.

Comment 8

[Wilson Page [:wilsonpage]]

Unable to reproduce.

This would be a result of controls UI becoming tappable when the camera hardware is still busy. I think this has since stabalised.

marcia, justindarc: can you still reproduce?

Comment 9

[Justin D'Arcangelo [:justindarc]]

I am still able to reproduce on Hamachi. I have a feeling it is something related to it being a camera without auto-focus capabilities. Looking into it now.

Comment 10

[Marcia Knous [:marcia]]

Definitely still happening for me on Buri using:

Gaia   874fe42b82e8d819d592690e74db91c07179e68c
SourceStamp 1417d180a1d8
BuildID 20140401040202
Version 31.0a1

Comment 11

[Josh Schmitt [Joshs]]

I am unable to repro on 1.3 Buri build

Environmental Variables:
Device: Buri 1.3 MOZ
BuildID: 20140401004003
Gaia: 24f562fce468fc948ac9e6185e002c23350cb9ee
Gecko: 0adf24a785f2
Version: 28.0
Firmware Version: V1.2-device.cfg

Comment 12

[Justin D'Arcangelo [:justindarc]]

Attachment: pull-request (master)

Comment 13

[Diego Marcos [:dmarcos]]

Created alternative pull request to ignore the camera control error when there's a picture in progress and a new capture is requested

Comment 14

[Diego Marcos [:dmarcos]]

Attachment: Alternative pull request

Comment 15

[Justin D'Arcangelo [:justindarc]]

Landed on master:

https://github.com/mozilla-b2g/gaia/commit/4f8805198e6b5f79bf4b2f4f5e14d6c9c276b180

Comment 16

[Jason Smith [:jsmith]]

Do we need this on 1.4? Or will this automatically be included in 1.4 once the camera new features branch goes to 1.4?

Comment 17

[Justin D'Arcangelo [:justindarc]]

jsmith: We plan on uplifting all the 1.4 patches on master to 1.4 tomorrow morning.

Comment 19

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

Marking as affecting 1.3T based on comment 18

Comment 20

[David Flanagan [:djf]]

Bulk edit for camera bugs.

If earlier comments do not show how this bug landed to master, it probably landed as part of https://github.com/mozilla-b2g/gaia/pull/17599 which merged the camera-new-features branch into master.

This bug was uplifted from master to v1.4 as part of https://github.com/mozilla-b2g/gaia/commit/a8190d08e61316a86bba572ba8d894d081a20530

Comment 21

[sarsenyev]

The bug is no longer reproduces on the latest Buri 1.4 and master builds
"Picture not saved" message didn't appear when tapping the "shutter" icon


1.4 Environmental Variables:
Device: Buri 1.4 MOZ
BuildID: 20140408000202
Gaia: 26983f356ecb1bcf30e862d334b5de790071803e
Gecko: 70b076fc7558
Version: 30.0a2
Firmware Version: v1.2-device.cfg

1.5 Environmental Variables:
Device: Buri Master 
BuildID: 20140408040204
Gaia: 1958454595b1fa0e061f0652ae965629993f5708
Gecko: 8883360b1edb
Version: 31.0a1
Firmware Version: v1.2-device.cfg