988656 - [B2G][Camera] Thumbnails persist after the target is deleted through Gallery

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Camera, defect)

Description

[Pi Wei Cheng [:piwei] (inactive)]

Attachment: video of issue occurred

Description:
The thumbnails at the top of the screen do not disappear after their targets are deleted from the Gallery app while the Camera app remains open

Repro Steps:
1) Update a Buri to BuildID: 20140326000201
2) Launch the Camera app
3) Take a picture
4) Tap on Gallery icon at bottom to access the Gallery
5) Delete the picture taken at step 3
6) Tap on Camera icon at bottom to go back to Camera
7) Bring up the Thumbnails strip at the top

Actual:
The deleted picture at step 3 appears at the top

Expected:
The deleted picture at step 3 does not appear at the top

v1.4 Environmental Variables:
Device: Buri v1.4 MOZ
BuildID: 20140326000201
Gaia: 7e705dd4718d528974d99ac31866318d7e201152
Gecko: 4889124accfa
Version: 30.0a2
Firmware Version: v1.2-device.cfg


Notes:
Repro frequency: (3/3)
See attached video and logcat.

Comment 1

[Pi Wei Cheng [:piwei] (inactive)]

Attachment: Logcat

Attaching logcat.

Comment 2

[Pi Wei Cheng [:piwei] (inactive)]

This issue does not reproduce on the 3/26/14 1.3 build.

Device: Buri v1.3 MOZ
BuildID: 20140326004002
Gaia: 812838ad0fabf51fa14435af562ddac6d26fa936
Gecko: ba97efb0da4b
Version: 28.0
Firmware Version: v1.2-device.cfg

Comment 3

[jcastro]

This fails test case ID 2852

Comment 4

[Jason Smith [:jsmith]]

What happens if you click on picture in the filmstrip?

Comment 5

[Pi Wei Cheng [:piwei] (inactive)]

Attachment: video file screenshot

Two things can happen when attempting to view deleted items from filmstrip.

1) If it's a video file, it displays a broken video UI. Screenshot of that is attached.

2) If it's a picture file, the app exits out itself which appears to be OOM.

Comment 6

[Brogan Zumwalt [Inactive]]

Can confirm this. Camera crashes to homescreen 5/5 times when thumbnail is clicked. No crash report.

dmesg snippet (OOM?):
<4>[  317.017356] select 656 (Camera), adj 10, size 6679, to kill
<4>[  317.017373] send sigkill to 656 (Camera), adj 10, size 6679

Environmental Variables:
Device: Buri v1.4 Mozilla RIL
BuildID: 20140326000201
Gaia: 7e705dd4718d528974d99ac31866318d7e201152
Gecko: 4889124accfa
Version: 30.0a2
Firmware Version: v1.2-device.cfg

Comment 7

[Jason Smith [:jsmith]]

Okay - if we're crashing & displaying broken UX, then this is pretty bad.

Comment 8

[Hema Koka [:hema]]

Marcia: Please test this out on master

Comment 9

[Hema Koka [:hema]]

blocking because it is regression

Comment 10

[Marcia Knous [:marcia]]

I don't see this using the latest master on Buri:

Gaia   26839cb46f856d610b192f5655a8c38a6bfe0829
SourceStamp d8e8f13bd4ae
BuildID 20140331040200
Version 31.0a1

Since there is a new preview flow I checked both the preview flow next to the shutter button as well as deleting pictures from Gallery itself. In both cases the picture was deleted properly.

Comment 11

[Ross Kuhlman ([e-mail])]

Issue first occurs in 12/23 build. In earlier builds, the picture is no longer displayed in the filmstrip after being deleted from gallery.

Last Working Environmental Variables:
Device: Buri
BuildID: 20140122040205
Gaia: 8d18b1e2fd06c84a879f99f6e8ca1f104eeacb13
Gecko: 8f4ecbf938cd
Version: 29.0a1
Base Image: V1.2-device.cfg

First Broken Environmental Variables:
Device: Buri
BuildID: 20140124040404
Gaia: 290efee3de3a12c9d803f4650d50bc7c7a8e1f2d
Gecko: 9d650c07b547
Version: 29.0a1
Base Image: V1.2-device.cfg

Comment 12

[Ross Kuhlman ([e-mail])]

Apologies, posted the wrong environmental variables in the previous comment. Here are the correct window variables.

Last Working Environmental Variables:
Device: Buri v1.4 Moz RIL
BuildID: 20140122040205
Gaia: 8d18b1e2fd06c84a879f99f6e8ca1f104eeacb13
Gecko: 8f4ecbf938cd
Version: 29.0a1
Base Image: V1.2-device.cfg

First Broken Environmental Variables:
Device: Buri v1.4 Moz RIL
BuildID: 20140123040608
Gaia: 00d8d05f0d0730a3cbf17635ad6a6b197a2ce7c9
Gecko: 1a75d37e1e39
Version: 29.0a1
Base Image: V1.2-device.cfg
RIL Version: 01.02.00.019.102

Gecko/Gaia and pushlog will be posted shortly

Comment 13

[Jason Smith [:jsmith]]

Leaving the window request here until we get the push logs.

Comment 14

[Ross Kuhlman ([e-mail])]

This is a Gecko issue.
http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=8f4ecbf938cd&tochange=1a75d37e1e39

Comment 15

[Jason Smith [:jsmith]]

(In reply to rkuhlman from comment #14)
> This is a Gecko issue.
> http://hg.mozilla.org/mozilla-central/
> pushloghtml?fromchange=8f4ecbf938cd&tochange=1a75d37e1e39

This can be reduced further - I'm seeing multiple pushes here. Can you use tinderbox m-c builds to reduce this further?

Comment 16

[J Zimbrick]

I worked with rkuhlman to find a new regression window for this issue. 

Unfortunately, this issue was introduced earlier than we have tinderbox builds available, so this window is still using nightly builds. 

Nightly Regression Window:

Last Working Environmental Variables:
Device: Buri
BuildID: 20140116040206
Gaia: 82878ba16172213cd00ba3e8b37756
4b290e59c1
Gecko: 324e2cba1029
Version: 29.0a1
Base Image: V1.2-device.cfg

First Broken Environmental Variables:
Device: Buri
BuildID: 20140117041037
Gaia: ef8bb31b462f364b57432a0724c78034d3f4f303
Gecko: b53589696cf8
Version: 29.0a1
Base Image: V1.2-device.cfg

Last Working Gaia / First Broken Gecko: Issue does NOT reproduce.
Gaia: 82878ba16172213cd00ba3e8b377564b290e59c1
Gecko: b53589696cf8

First Broken Gaia / Last Working Gecko: Issue DOES reproduce.
Gaia: ef8bb31b462f364b57432a0724c78034d3f4f303
Gecko: 324e2cba1029

Gaia Pushlog: https://github.com/mozilla-b2g/gaia/compare/82878ba16172213cd00ba3e8b377564b290e59c1...ef8bb31b462f364b57432a0724c78034d3f4f303

Comment 17

[Hema Koka [:hema]]

(In reply to Marcia Knous [:marcia - use needinfo] from comment #10)
> I don't see this using the latest master on Buri:
> 
> Gaia   26839cb46f856d610b192f5655a8c38a6bfe0829
> SourceStamp d8e8f13bd4ae
> BuildID 20140331040200
> Version 31.0a1
> 
> Since there is a new preview flow I checked both the preview flow next to
> the shutter button as well as deleting pictures from Gallery itself. In both
> cases the picture was deleted properly.


Please verify - new camera features landed today. Marking this fixed

Comment 18

[Jason Smith [:jsmith]]

Marcia - Can you check if this works fine with 1.4 with the new camera new features branch?

Comment 19

[Marcia Knous [:marcia]]

(In reply to Jason Smith [:jsmith] from comment #18)
> Marcia - Can you check if this works fine with 1.4 with the new camera new
> features branch?

Works fine with me on Buri using:

Gaia   b4f3b84ec68233a99fd5865c15cfe28aebe26531
SourceStamp 3186bbc50050
BuildID 20140404000202
Version 30.0a2