Closed Bug 988722 Opened 6 years ago Closed 6 years ago

Use buildprops.json to decide whether and how to use sccache

Categories

(Firefox Build System :: General, defect)

defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
mozilla31

People

(Reporter: glandium, Assigned: glandium)

References

Details

Attachments

(1 file)

No description provided.
I'd really rather not add more dependency on this file, especially directly from the build system. What if we set an environment variable instead, a la $MOZ_UPDATE_CHANNEL? Eg, MOZ_DATACENTRE could be "use1", "usw2", "scl3", etc.
Flags: needinfo?(mh+mozilla)
(In reply to Ben Hearsum [:bhearsum] from comment #2)
> I'd really rather not add more dependency on this file, especially directly
> from the build system. What if we set an environment variable instead, a la
> $MOZ_UPDATE_CHANNEL? Eg, MOZ_DATACENTRE could be "use1", "usw2", "scl3", etc.

I'm all for it, but catlee didn't seem to want to in bug 985263.
Flags: needinfo?(mh+mozilla)
Comment on attachment 8397606 [details] [diff] [review]
Use buildprops.json to decide whether and how to use sccache

Review of attachment 8397606 [details] [diff] [review]:
-----------------------------------------------------------------

Well, turns out that we can't find a quick way of doing this better, and I don't want to block you any longer.

I should note that since you're relying on master that there's a possibility of this being incorrect. These days we try to keep slaves on a master in the same colo, but there's no guarantee of that.
Attachment #8397606 - Flags: review?(bhearsum) → review+
https://hg.mozilla.org/mozilla-central/rev/8245a010d297
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla31
Blocks: 985263
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.