988722 - Use buildprops.json to decide whether and how to use sccache

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Comment 1

[Mike Hommey [:glandium]]

Attachment: Use buildprops.json to decide whether and how to use sccache

Comment 2

[[e-mail] (:bhearsum)]

I'd really rather not add more dependency on this file, especially directly from the build system. What if we set an environment variable instead, a la $MOZ_UPDATE_CHANNEL? Eg, MOZ_DATACENTRE could be "use1", "usw2", "scl3", etc.

Comment 3

[Mike Hommey [:glandium]]

(In reply to Ben Hearsum [:bhearsum] from comment #2)
> I'd really rather not add more dependency on this file, especially directly
> from the build system. What if we set an environment variable instead, a la
> $MOZ_UPDATE_CHANNEL? Eg, MOZ_DATACENTRE could be "use1", "usw2", "scl3", etc.

I'm all for it, but catlee didn't seem to want to in bug 985263.

Comment 4

[[e-mail] (:bhearsum)]

Comment on attachment 8397606 [details] [diff] [review]
Use buildprops.json to decide whether and how to use sccache

Review of attachment 8397606 [details] [diff] [review]:
-----------------------------------------------------------------

Well, turns out that we can't find a quick way of doing this better, and I don't want to block you any longer.

I should note that since you're relying on master that there's a possibility of this being incorrect. These days we try to keep slaves on a master in the same colo, but there's no guarantee of that.

Comment 5

[Mike Hommey [:glandium]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/8245a010d297

Comment 6

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/8245a010d297