988744 - orangefactor template_before_process should check $file before checking user settings

Status: RESOLVED FIXED

(bugzilla.mozilla.org :: Extensions, defect)

Description

[:glob ✱]

currently the orange factor extension does:

>    return unless $user && $user->id && $user->settings;
>    return unless $user->settings->{'orange_factor'}->{'value'} eq 'on';
>
>    # in the header we just need to set the var,
>    # to ensure the css and javascript get included
>    if ($file eq 'bug/show-header.html.tmpl'
>        || $file eq 'bug/edit.html.tmpl') {

this can result in two unnecessary database queries to load the user's settings (eg. when rendering the xml version of a page).

$file should be checked first, then $user->settings.

Comment 1

[David Lawrence [:dkl]]

Attachment: 988744_1.patch

Comment 2

[:glob ✱]

Comment on attachment 8397857 [details] [diff] [review]
988744_1.patch

Review of attachment 8397857 [details] [diff] [review]:
-----------------------------------------------------------------

r=glob

Comment 3

[David Lawrence [:dkl]]

To ssh://[e-mail]/webtools/bmo/bugzilla.git
   07ae825..5ee0201  4.2 -> 4.2