988845 - Generating a call-url should allow a "duration" parameter.

Status: VERIFIED FIXED

(Hello (Loop) :: Server, defect)

Description

[Alexis Metaireau (:alexis)]

We should allow the users to specify how long a token is valid for.

Comment 1

[Mark Banner (:standard8)]

Where's the requirement for this come from? This choice would seem to be unnecessarily complex from a user's point of view.

Also, I don't see this blocking MLP.

Comment 2

[Rémy Hubscher (:natim)]

This is important to be able to know for how long we want to store token revocation.

For MLP on client side we can use the default value of one month but to keep database integrity, we need to be carefull of the storing time of each record.

Comment 3

[Mark Banner (:standard8)]

Why doesn't the server control this for now, until there's a clear user requirement?

Comment 4

[Alexis Metaireau (:alexis)]

Let me clarify this: this is optional on the client. You don't *need* to specify the option, but if you do it should be taken in consideration.

Comment 5

[Alexis Metaireau (:alexis)]

https://github.com/mozilla-services/loop-server/commit/64b02b07a0e594c57f39d431893c30c72b36768d

Comment 6

[u279076]

Is there any UI hooked up to test this? I can't seem to find any in the desktop client.

Comment 7

[James Bonacci [:jbonacci]]

I think  there would only be a UI requirement in the client chooses to expose this. As of right now, it lives on the server, only, which means it could be configured on the server, as needed.

Comment 8

[u279076]

(In reply to James Bonacci [:jbonacci] from comment #7)
> I think  there would only be a UI requirement in the client chooses to
> expose this. As of right now, it lives on the server, only, which means it
> could be configured on the server, as needed.

Any chance that could be done as a one-off to test this is working correctly? or is this sufficiently covered with automation?

Comment 9

[James Bonacci [:jbonacci]]

If it stays on server, it is sufficiently covered with the unit testing:
loop-server/test/functional_test.js

So, yea, we could mess with it a bit on the server side if we wanted (especially on the Stage environment).

Comment 10

[u279076]

Okay, assuming verified fixed based on unit tests. We'll want to retest this manually if we every decide to implement this in the client though.