988930 - Auth view button overlaps text in landscape mode on phones

Status: RESOLVED WONTFIX

(Firefox for Android Graveyard :: Awesomescreen, defect, P2)

Description

[:Margaret Leibovic]

Just noticed this while testing my patches for bug 942281, but I didn't want to block landing that.

Comment 1

[:Margaret Leibovic]

I think we should take this opportunity to do a polish pass on the auth layout. Here's what things currently look like on my Nexus 4:

https://dl.dropboxusercontent.com/u/3358452/auth-portrait.png
https://dl.dropboxusercontent.com/u/3358452/auth-landscape.png

We should find a solution that works on different screen resolutions, maybe we can follow what liuche did for empty views.

We also let add-on authors specify their own image here if they want, and we should come up with a recommended image size that we can document.

Comment 2

[Ian Barlow (:ibarlow)]

Attachment: mockup

I think there are a couple things we can do here that could help: 

1. Group the icon, text and button together so that the button doesn't crash into the text if the screen is too short. We really shouldn't be treating the button as an overlay, that just seems like a risky move. This way, even if the screen is too short to show everything, users can just scroll a bit if they have to. It's not perfect, but better than content crashing into other content. 

2. Use a slightly smaller image size, one that matches what we use in our empty panel placeholders. (90x90dp)

Comment 3

[:Margaret Leibovic]

Setting P2 hub bugs to block hub v2 EPIC bug (targeting fx31 release).

Filter on epic-hub-bugs.

Comment 4

[:Margaret Leibovic]

I haven't had time to get to this, marking it as a mentor bug in case someone else can get to it first.

Comment 5

[:Margaret Leibovic]

I don't think we should spend more time investing in this add-on API until we have consumers complaining about it.