989093 - Please remove hamachi.zip and the out folder from the ril build for hamachi

Status: RESOLVED FIXED

(Release Engineering :: General, defect)

Description

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

1) https://pvtbuilds.mozilla.org/pvt/mozilla.org/b2gotoro/nightly/mozilla-central-hamachi/2014/03/2014-03-27-09-28-14/ 
has hamachi.zip which we don't use to flash and can cause some issues since the gonk configuration is not quite right.

2) https://pvtbuilds.mozilla.org/pvt/mozilla.org/b2g_ril/hamachi-eng-mozilla-central-20140327092814-ril01.02.00.019.102.zip
contains : out and flash.sh 
which we never use.

Please remove them from the build structure.

Comment 1

[Aki Sasaki (not active)]

Attachment: kill_hamachi_zip

Comment 2

[Aki Sasaki (not active)]

Attachment: Allow for no hamachi.zip in the ril repack

Comment 3

[Aki Sasaki (not active)]

Comment on attachment 8398231 [details] [diff] [review]
kill_hamachi_zip

https://hg.mozilla.org/integration/b2g-inbound/rev/186f509732b6

Comment 4

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/186f509732b6

Comment 5

[Robert Wood [:rwood]]

Sources.xml is now missing from the b2g_ril hamachi eng builds:

https://pvtbuilds.mozilla.org/pvt/mozilla.org/b2g_ril/latest-hamachi-eng-mozilla-central/hamachi-eng-mozilla-central-latest.zip

I'm assuming that wasn't intended...

Comment 6

[Aki Sasaki (not active)]

Attachment: if no zipfile, grab sources.xml

Comment 7

[Aki Sasaki (not active)]

Comment on attachment 8398249 [details] [diff] [review]
Allow for no hamachi.zip in the ril repack

This was checked in with two bustage fixes:

fc099e44d8d07f2abafc19bd975e935c16a1e954
f43ad9e5fce0639f18804f7bd3db7eeedf719182
872c91a071462087ddbce91fac2a29e7ebc444fc

Comment 8

[Aki Sasaki (not active)]

(In reply to Robert Wood [:rwood] from comment #5)
> Sources.xml is now missing from the b2g_ril hamachi eng builds:
> 
> https://pvtbuilds.mozilla.org/pvt/mozilla.org/b2g_ril/latest-hamachi-eng-
> mozilla-central/hamachi-eng-mozilla-central-latest.zip
> 
> I'm assuming that wasn't intended...

Right. Looks like the sources.xml was from the zipfile, so once we stopped generating/grabbing/unzipping the zipfile, the sources.xml disappeared from the repack.

We should see it in any new repacks, assuming my patch works correctly.

Comment 9

[Aki Sasaki (not active)]

Comment on attachment 8400239 [details] [diff] [review]
if no zipfile, grab sources.xml

Checked in, with a bustage fix.  This is now grabbing sources.xml if it's not grabbing the zipfile.
e8d268369f0d64229771173b4d31510948ace9ce
af882894f058cb1f49ad1bf1ee2df7769d6d317a

Comment 10

[Robert Wood [:rwood]]

Thanks :aki, yep sources.xml is now back in hamachi-eng-mozilla-central-latest.zip

Comment 11

[Dave Hunt [:davehunt] [he/him] ⌚BST]

We had several download jobs that were watching this file to determine when a new build was available. I've updated all of these to now use the sources.xml file.

Comment 12

[(not reading bugmail) Nick Desaulniers [:\n]]

So does that mean we can no longer flash full from the TWQA tool? https://github.com/Mozilla-TWQA/B2G-flash-tool/issues/149