Please remove hamachi.zip and the out folder from the ril build for hamachi

RESOLVED FIXED

Status

defect
RESOLVED FIXED
5 years ago
a year ago

People

(Reporter: nhirata, Assigned: aki)

Tracking

Firefox Tracking Flags

(b2g-v1.2 fixed, b2g-v1.3 fixed, b2g-v1.3T unaffected, b2g-v1.4 fixed, b2g-v2.0 fixed)

Details

Attachments

(3 attachments)

1) https://pvtbuilds.mozilla.org/pvt/mozilla.org/b2gotoro/nightly/mozilla-central-hamachi/2014/03/2014-03-27-09-28-14/ 
has hamachi.zip which we don't use to flash and can cause some issues since the gonk configuration is not quite right.

2) https://pvtbuilds.mozilla.org/pvt/mozilla.org/b2g_ril/hamachi-eng-mozilla-central-20140327092814-ril01.02.00.019.102.zip
contains : out and flash.sh 
which we never use.

Please remove them from the build structure.
(Assignee)

Comment 1

5 years ago
Assignee: nobody → aki
Attachment #8398231 - Flags: review?(catlee)
Attachment #8398231 - Flags: review?(catlee) → review+
(Assignee)

Comment 2

5 years ago
Attachment #8398249 - Flags: review?(rail)

Updated

5 years ago
Attachment #8398249 - Flags: review?(rail) → review+
(Assignee)

Updated

5 years ago
Keywords: leave-open
(Assignee)

Updated

5 years ago
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Sources.xml is now missing from the b2g_ril hamachi eng builds:

https://pvtbuilds.mozilla.org/pvt/mozilla.org/b2g_ril/latest-hamachi-eng-mozilla-central/hamachi-eng-mozilla-central-latest.zip

I'm assuming that wasn't intended...
Flags: needinfo?(aki)
(Assignee)

Comment 6

5 years ago
Attachment #8400239 - Flags: review?(rail)
Flags: needinfo?(aki)
(Assignee)

Comment 7

5 years ago
Comment on attachment 8398249 [details] [diff] [review]
Allow for no hamachi.zip in the ril repack

This was checked in with two bustage fixes:

fc099e44d8d07f2abafc19bd975e935c16a1e954
f43ad9e5fce0639f18804f7bd3db7eeedf719182
872c91a071462087ddbce91fac2a29e7ebc444fc
Attachment #8398249 - Flags: checked-in+

Updated

5 years ago
Attachment #8400239 - Flags: review?(rail) → review+
(Assignee)

Comment 8

5 years ago
(In reply to Robert Wood [:rwood] from comment #5)
> Sources.xml is now missing from the b2g_ril hamachi eng builds:
> 
> https://pvtbuilds.mozilla.org/pvt/mozilla.org/b2g_ril/latest-hamachi-eng-
> mozilla-central/hamachi-eng-mozilla-central-latest.zip
> 
> I'm assuming that wasn't intended...

Right. Looks like the sources.xml was from the zipfile, so once we stopped generating/grabbing/unzipping the zipfile, the sources.xml disappeared from the repack.

We should see it in any new repacks, assuming my patch works correctly.
(Assignee)

Comment 9

5 years ago
Comment on attachment 8400239 [details] [diff] [review]
if no zipfile, grab sources.xml

Checked in, with a bustage fix.  This is now grabbing sources.xml if it's not grabbing the zipfile.
e8d268369f0d64229771173b4d31510948ace9ce
af882894f058cb1f49ad1bf1ee2df7769d6d317a
Attachment #8400239 - Flags: checked-in+
Thanks :aki, yep sources.xml is now back in hamachi-eng-mozilla-central-latest.zip
We had several download jobs that were watching this file to determine when a new build was available. I've updated all of these to now use the sources.xml file.
So does that mean we can no longer flash full from the TWQA tool? https://github.com/Mozilla-TWQA/B2G-flash-tool/issues/149
Component: General Automation → General
Product: Release Engineering → Release Engineering
You need to log in before you can comment on or make changes to this bug.