Closed
Bug 989151
Opened 11 years ago
Closed 11 years ago
Pref on firefox accounts
Categories
(Firefox OS Graveyard :: FxA, defect)
Tracking
(b2g-v2.0 fixed)
RESOLVED
FIXED
2.0 S1 (9may)
| Tracking | Status | |
|---|---|---|
| b2g-v2.0 | --- | fixed |
People
(Reporter: jhirsch, Assigned: jhirsch)
References
Details
(Whiteboard: [qa+])
Attachments
(1 file, 1 obsolete file)
Set "identity.fxaccounts.ui.enabled": true now that 1.4 has branched.
|
Assignee | |
Comment 1•11 years ago
|
||
Attachment #8398237 -
Flags: review?(ferjmoreno)
|
|
Assignee | |
Updated•11 years ago
|
Assignee: nobody → 6a68
|
||
Comment 4•11 years ago
|
||
Comment on attachment 8398237 [details] [review]
Github PR 17733
LGTM but we need to make sure that we don't break Travis.
Attachment #8398237 -
Flags: review?(ferjmoreno) → feedback+
|
|
Assignee | |
Comment 5•11 years ago
|
||
Rebased and force-pushed to the branch, we'll see what Travis has to say about it.
|
|
Assignee | |
Comment 6•11 years ago
|
||
Comment on attachment 8398237 [details] [review]
Github PR 17733
ferjm, Travis seems happy now (I fixed an FTU test). Good to merge?
Attachment #8398237 -
Flags: review?(ferjmoreno)
|
|
Assignee | |
Comment 7•11 years ago
|
||
Hmm. RyanVM, I'm not sure if the preceding means this code is ok to merge or not, I'd like your opinion:
* ferjm gave f+ and said "LGTM", provided Travis is green
* I made a one-liner change to a test to get Travis green
Does this add up to r+? If it's close enough, especially given that this is a tiny change, I'd love to get this merged today (vs waiting overnight for a response from ferjm).
Thoughts?
Flags: needinfo?(ryanvm)
|
|
Assignee | |
Comment 9•11 years ago
|
||
Awesome, thanks RyanVM! I'll wait for ferjm to give the r+ :-)
|
|
Assignee | |
Comment 10•11 years ago
|
||
Travis stopped running tests when I pushed to the original pull request. So, I closed that pull request and opened this new one. Same code as before.
Attachment #8398237 -
Attachment is obsolete: true
Attachment #8398237 -
Flags: review?(ferjmoreno)
Attachment #8404353 -
Flags: review?(ferjmoreno)
|
|
||
Updated•11 years ago
|
Attachment #8404353 -
Flags: review?(ferjmoreno) → review+
|
||
Updated•11 years ago
|
Whiteboard: [qa+]
|
|
Assignee | |
Comment 11•11 years ago
|
||
Awesome, thank you ferjm and npark! Merging now.
|
|
Assignee | |
Comment 12•11 years ago
|
||
Status: NEW → RESOLVED
Closed: 11 years ago
status-b2g-v2.0:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 1.5 S1 (9may)
You need to log in
before you can comment on or make changes to this bug.
Description
•