989192 - Create portal detection events on network topology changes and user login

Status: RESOLVED WORKSFORME

(Firefox :: Address Bar, enhancement, P2)

Description

[Jennifer Morrow [:Boriss] (UX)]

As part of Firefox's Captive Portal Design, this bug creates a captive portal detection event on network topology changes and on user login to a captive portal.  

Firefox captive portal detection should assume the user may authenticate with a captive portal outside of Firefox (e.g other browser, or system interaction). It should attempt to update the captive portal state as best as it can in these scenarios and hide any captive portal UI elements once the user is not behind a captive portal anymore.

More information on detection needed for OSX and Windows: https://github.com/vtsatskin/FX-Captive-Portals-Design/blob/master/detection.md

Note: Implementation followup from design Bug 878566
Whole Captive Portal Spec: https://github.com/vtsatskin/FX-Captive-Portals-Design/blob/master/design/spec.md

Comment 1

[(inactive) Nihanth Subramanya [:nhnt11]]

Attachment: WIP

I threw together a basic WIP today. This uses XHR to try and detect a captive portal, based on https://www.chromium.org/chromium-os/chromiumos-design-docs/network-portal-detection.

TODO:
1. We probably want our own "test page" (maybe an existing one, maybe a new one). I'm piggybacking on Google for now.
2. Some sort of state object needs to be implemented with an API.
3. I haven't implemented login detection yet. I suspect that once we know there's a captive portal, we can watch for successful requests to URLs other than the captive portal one, and then re-test and update state.

Comment 2

[Matthew N. [:MattN]]

Hey Nihanth, you may want to look at https://mxr.mozilla.org/mozilla-central/source/toolkit/components/captivedetect/ if you haven't already. We already have a detection endpoint for FxOS that you can probably use. I think Valentin Gosu may have some other code for captive portals too.

Comment 3

[Valentin Gosu [:valentin] (he/him) {{ FYI: OOO 14 June - 4 August }}]

A large part of this is already implemented in the code Matt linked to and bug 1048131 implements a captive portal detection service.

Comment 4

[(inactive) Nihanth Subramanya [:nhnt11]]

The events are already generated in captivedetect.js linked above. Closing this bug.