989196 - Do not show open Captive Portal automatically when OSX Captive Network Portal Assistant has been opened

Status: RESOLVED WORKSFORME

(Firefox :: Address Bar, enhancement, P3)

Description

[Jennifer Morrow [:Boriss] (UX)]

Note: Implementation followup from design Bug 878566
Spec: https://github.com/vtsatskin/FX-Captive-Portals-Design/blob/master/design/spec.md

As part of Firefox's Captive Portal Design, this bug adds OSX Captive Network Assistant observation events and detects when Captive Network Assistant failed.

Starting in Mac OS X 10.7, a window appears when a captive portal has been detected by the OS.

This may cause duplicated captive portals on the screen. If it's possible, Firefox should watch to see if Captive Network Assistant opens a captive portal. If it does, there is no need to automatically open it in Firefox. However, if the system does not properly detect a captive portal, Firefox should behave as defined in this spec.

For users, the outcome is that if an OSX-level Captive Portal is visible, a captive portal does not automatically open in Firefox.

Acceptance Criteria:

- Firefox determines if an OSX-level captive portal is visible to the user in the foreground.
- If the user logs into the OSX-level captive portal, Firefox never automatically opens the captive portal in a tab.
- If the user does not log into the OSX-level captive portal, Firefox automatically opens a tab in the active window with a captive portal

Comment 1

[ovidiu boca[:Ovidiu]]

I tested on Mac OS X 10.12 with FF DeveloperEdition 52.0a2(2017-01-19) and I can't reproduce the issue from description. I will mark this as Resolved WFM.