989199 - xpfe/components/directory/nsDirectoryViewer.cpp:58:18 [-Wunused-const-variable] unused variable 'FORMAT_HTML'

Status: RESOLVED FIXED

(Core :: XUL, defect, P4)

Description

[Chris Peterson [:cpeterson]]

Attachment: fix-xpfe-warning.patch

Fix that last OS X clang warning in the xpfe/ directory:

xpfe/components/directory/nsDirectoryViewer.cpp:58:18 [-Wunused-const-variable] unused variable 'FORMAT_HTML'

Comment 1

[Chris Peterson [:cpeterson]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/9051a06f0268

Comment 2

[Daniel Holbert [:dholbert]]

Thanks for fixing this!

Are you planning on marking this directory as FAIL_ON_WARNINGS, now, too? (hoping that there aren't any warnings on e.g. MSVC -- or if there are any, hoping that they're trivial to fix)

Comment 3

[Chris Peterson [:cpeterson]]

(In reply to Daniel Holbert [:dholbert] from comment #2)
> Are you planning on marking this directory as FAIL_ON_WARNINGS, now, too?
> (hoping that there aren't any warnings on e.g. MSVC -- or if there are any,
> hoping that they're trivial to fix)

This directory does not have any warnings on OS X or Android. I don't have a Windows or Linux build environment so let's give this a try:

https://tbpl.mozilla.org/?tree=Try&rev=a9cf6064dbfc

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/9051a06f0268

Comment 5

[Daniel Holbert [:dholbert]]

(In reply to Chris Peterson (:cpeterson) from comment #3)
> (In reply to Daniel Holbert [:dholbert] from comment #2)
> > Are you planning on marking this directory as FAIL_ON_WARNINGS, now, too?
>
> https://tbpl.mozilla.org/?tree=Try&rev=a9cf6064dbfc

Try run looks good (and patch looks good to me)!

Perhaps post a patch (or file a followup) & request review from Neil Rashbrook (module owner for /xpfe [1]), to make it so?

[1] https://wiki.mozilla.org/Modules/Core#XPApps

Comment 6

[Chris Peterson [:cpeterson]]

Attachment: FAIL_ON_WARNINGS_nsDirectoryViewer.patch

Part 2: Compile xpfe/components/directory with FAIL_ON_WARNINGS.

Comment 7

[[e-mail]]

Comment on attachment 8400195 [details] [diff] [review]
FAIL_ON_WARNINGS_nsDirectoryViewer.patch

Do we have a style guide for moz.build files? Picking one at random, it seems to double-space everything, so you would want to add a blank line.

Comment 8

[Daniel Holbert [:dholbert]]

(That's the convention I recall seeing, too, FWIW.)

Comment 9

[Chris Peterson [:cpeterson]]

I landed this patch with the extra blank line, as suggested:

https://hg.mozilla.org/integration/mozilla-inbound/rev/75dc2e17b980

Comment 10

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/75dc2e17b980

Comment 11

[Firefox Commit Bot]

The following changeset is now in Firefox Nightly:

> 9051a06f0268 Bug 989199 - Fix -Wunused-const-variable warning in xpfe. r=janv

Nightly Build Information:

        ID: 20140402030201
 Changeset: 4941a2ac0786109b08856738019b016a6c5a66a6
   Version: 31.0a1
      TBPL: https://tbpl.mozilla.org/?rev=4941a2ac0786
       URL: https://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/2014/04/2014-04-02-03-02-01-mozilla-central

Download Links:

>         Linux x86: https://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/2014/04/2014-04-02-03-02-01-mozilla-central/firefox-31.0a1.en-US.linux-i686.tar.bz2
>      Linux x86_64: https://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/2014/04/2014-04-02-03-02-01-mozilla-central/firefox-31.0a1.en-US.linux-x86_64.tar.bz2
> Linux x86_64 ASAN: https://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/2014/04/2014-04-02-03-02-01-mozilla-central/firefox-31.0a1.en-US.linux-x86_64-asan.tar.bz2
>               Mac: https://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/2014/04/2014-04-02-03-02-01-mozilla-central/firefox-31.0a1.en-US.mac.dmg
>             Win32: https://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/2014/04/2014-04-02-03-02-01-mozilla-central/firefox-31.0a1.en-US.win32.installer.exe
>             Win64: https://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/2014/04/2014-04-02-03-02-01-mozilla-central/firefox-31.0a1.en-US.win64-x86_64.installer.exe

Previous Nightly Build Information:

        ID: 20140401030203
 Changeset: 1417d180a1d8665b1a91b897d1cc4cc31e7980d4
   Version: 31.0a1
      TBPL: https://tbpl.mozilla.org/?rev=1417d180a1d8
       URL: https://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/2014/04/2014-04-01-03-02-03-mozilla-central

Comment 12

[Firefox Bug Husbandry Bot]

Moving to Core:XUL per https://bugzilla.mozilla.org/show_bug.cgi?id=1455336