Closed Bug 989199 Opened 6 years ago Closed 6 years ago
Directory Viewer .cpp:58:18 [-Wunused-const-variable] unused variable 'FORMAT _HTML'
Fix that last OS X clang warning in the xpfe/ directory: xpfe/components/directory/nsDirectoryViewer.cpp:58:18 [-Wunused-const-variable] unused variable 'FORMAT_HTML'
Attachment #8398333 - Flags: review?(Jan.Varga)
Thanks for fixing this! Are you planning on marking this directory as FAIL_ON_WARNINGS, now, too? (hoping that there aren't any warnings on e.g. MSVC -- or if there are any, hoping that they're trivial to fix)
(In reply to Daniel Holbert [:dholbert] from comment #2) > Are you planning on marking this directory as FAIL_ON_WARNINGS, now, too? > (hoping that there aren't any warnings on e.g. MSVC -- or if there are any, > hoping that they're trivial to fix) This directory does not have any warnings on OS X or Android. I don't have a Windows or Linux build environment so let's give this a try: https://tbpl.mozilla.org/?tree=Try&rev=a9cf6064dbfc
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla31
(In reply to Chris Peterson (:cpeterson) from comment #3) > (In reply to Daniel Holbert [:dholbert] from comment #2) > > Are you planning on marking this directory as FAIL_ON_WARNINGS, now, too? > > https://tbpl.mozilla.org/?tree=Try&rev=a9cf6064dbfc Try run looks good (and patch looks good to me)! Perhaps post a patch (or file a followup) & request review from Neil Rashbrook (module owner for /xpfe ), to make it so?  https://wiki.mozilla.org/Modules/Core#XPApps
Part 2: Compile xpfe/components/directory with FAIL_ON_WARNINGS.
Attachment #8400195 - Flags: review?(neil)
Comment on attachment 8400195 [details] [diff] [review] FAIL_ON_WARNINGS_nsDirectoryViewer.patch Do we have a style guide for moz.build files? Picking one at random, it seems to double-space everything, so you would want to add a blank line.
Attachment #8400195 - Flags: review?(neil) → review+
(That's the convention I recall seeing, too, FWIW.)
I landed this patch with the extra blank line, as suggested: https://hg.mozilla.org/integration/mozilla-inbound/rev/75dc2e17b980
The following changeset is now in Firefox Nightly: > 9051a06f0268 Bug 989199 - Fix -Wunused-const-variable warning in xpfe. r=janv Nightly Build Information: ID: 20140402030201 Changeset: 4941a2ac0786109b08856738019b016a6c5a66a6 Version: 31.0a1 TBPL: https://tbpl.mozilla.org/?rev=4941a2ac0786 URL: https://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/2014/04/2014-04-02-03-02-01-mozilla-central Download Links: > Linux x86: https://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/2014/04/2014-04-02-03-02-01-mozilla-central/firefox-31.0a1.en-US.linux-i686.tar.bz2 > Linux x86_64: https://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/2014/04/2014-04-02-03-02-01-mozilla-central/firefox-31.0a1.en-US.linux-x86_64.tar.bz2 > Linux x86_64 ASAN: https://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/2014/04/2014-04-02-03-02-01-mozilla-central/firefox-31.0a1.en-US.linux-x86_64-asan.tar.bz2 > Mac: https://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/2014/04/2014-04-02-03-02-01-mozilla-central/firefox-31.0a1.en-US.mac.dmg > Win32: https://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/2014/04/2014-04-02-03-02-01-mozilla-central/firefox-31.0a1.en-US.win32.installer.exe > Win64: https://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/2014/04/2014-04-02-03-02-01-mozilla-central/firefox-31.0a1.en-US.win64-x86_64.installer.exe Previous Nightly Build Information: ID: 20140401030203 Changeset: 1417d180a1d8665b1a91b897d1cc4cc31e7980d4 Version: 31.0a1 TBPL: https://tbpl.mozilla.org/?rev=1417d180a1d8 URL: https://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/2014/04/2014-04-01-03-02-03-mozilla-central
Moving to Core:XUL per https://bugzilla.mozilla.org/show_bug.cgi?id=1455336
Component: XP Toolkit/Widgets: XUL → XUL
You need to log in before you can comment on or make changes to this bug.