Closed
Bug 989212
Opened 10 years ago
Closed 10 years ago
Rename nsEventStates to mozilla::EventStates
Categories
(Core :: DOM: Events, defect)
Core
DOM: Events
Tracking
()
RESOLVED
FIXED
mozilla31
People
(Reporter: masayuki, Assigned: masayuki)
References
Details
Attachments
(1 file)
259.08 KB,
patch
|
smaug
:
review+
|
Details | Diff | Splinter Review |
No description provided.
Assignee | ||
Comment 1•10 years ago
|
||
It might be better to define NS_EVENT_STATE_* as constant in mozilla:: namespace. But it should be worked in another bug if it's necessary.
Attachment #8399865 -
Flags: review?(bugs)
Assignee | ||
Comment 2•10 years ago
|
||
And the patch makes all cpp files which use EventState class or NS_EVENT_STATE_* include the header.
Comment 3•10 years ago
|
||
Comment on attachment 8399865 [details] [diff] [review] Patch Update IID of Element and nsIDocument and Link +EventStateManager::SetContentState(nsIContent *aContent, EventStates aState) While you're here, want to move * to be next to nsIContent, not aContent. + EventStates eventState = + GetContentState(isXULCheckboxRadio ? aFrame->GetParent() : aFrame, aWidgetType); Indentation for aWidgetType is odd
Attachment #8399865 -
Flags: review?(bugs) → review+
Assignee | ||
Comment 4•10 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/b29352bc495f
Comment 5•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/b29352bc495f
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla31
You need to log in
before you can comment on or make changes to this bug.
Description
•