989221 - [B2G] [Gaia] Duplicate error alerts are displayed when video app encounters an error

Status: RESOLVED WONTFIX

(Firefox OS Graveyard :: Gaia::Video, defect)

Description

[Ethan Tseng [:ethan]]

Summary:
The error alert window is displayed twice when the video app encounters an error.

Reproduction Steps:
I found this bug while testing some error cases of RTSP streaming. The RTSP video feature is disabled by default in v1.3 and v1.4. For anyone to reproduce this bug with RSTP, you must enable RTSP video preference first.

However, it is easier to reproduce using the UI Test gaia app.
I just modified gaia/test_apps/uitest/js/API/openvideo.js
In open.onclick function block:
//blog: videoblob
url: 'invalid url'

Then, while clicking the "Open video" button, we can see the error alert window is popped out twice.

Comment 1

[Ethan Tseng [:ethan]]

Attachment: video_app_error_rtsp_streaming.mov

Using the video app to play a nonexistent RTSP streaming source.

Comment 2

[Ethan Tseng [:ethan]]

Attachment: video_app_error_uitest.mov

Using UI Test app to launch the video app to play a invalid URL.

Comment 3

[Ethan Tseng [:ethan]]

Hi John, could you help to forward this bug to the appropriate owner?

Comment 4

[Ethan Tseng [:ethan]]

(In reply to Ethan Tseng [:ethan] from comment #0)
> I found this bug while testing some error cases of RTSP streaming. The RTSP
> video feature is disabled by default in v1.3 and v1.4. For anyone to
> reproduce this bug with RSTP, you must enable RTSP video preference first.
Correct this statement.
The reproduction of this bug can be irrelevant to RTSP video enable/disable preference.
We could see this bug by just clicking any invalid RTSP URL, such as "rtsp://xxxxx", to launch the video app and wait it emit the alerts.

Comment 5

[John Hu [:johnhu][:johu][:醬糊小弟]]

As Ethan and I discuss offline, we found the Video app only receives one error message.

I had tested with code to disable "done()" function call[1]. So, the view activity won't be closed when we get an error. In this case, we only get one error and call alert once. When we long press home button, the view activity window is closed and press the caller app to get caller back. I found there another alert is shown on top of the caller's window.

[1] https://github.com/mozilla-b2g/gaia/blob/master/apps/video/js/view.js#L316

Alive or Gene, IIRC, you are the one handles alert from gecko and system app. Do you have any suggestion on this one?

Comment 6

[(inactive after 6/18) Alive Kuo [:alive]]

Can you debug in https://github.com/mozilla-b2g/gaia/blob/master/apps/system/js/app_modal_dialog.js#L47 to see which is evt.target?

Comment 7

[John Hu [:johnhu][:johu][:醬糊小弟]]

Log:

E/GeckoConsole( 1124): Content JS LOG at app://video.gaiamobile.org/js/view.js:315 in handleError: error
E/GeckoConsole( 1030): Content JS LOG at app://system.gaiamobile.org/js/app_modal_dialog.js:48 in amd_handleEvent: app://video.gaiamobile.org/view.html
E/GeckoConsole( 1030): Content JS LOG at app://system.gaiamobile.org/js/app_modal_dialog.js:48 in amd_handleEvent: app://video.gaiamobile.org/view.html

It calls twice. But view.js only calls once. It looks like gecko sent twice event to gaia.

Comment 8

[(inactive after 6/18) Alive Kuo [:alive]]

Try backout this locally https://github.com/mozilla-b2g/gaia/pull/16888
and retries. If that still happens it's a gecko bug indeed. But we could also request regression-window though.

Comment 9

[Gene Lian (I already quit Mozilla)]

Does the error message come from the system message? As far as I know, we don't have changes on system message in the past months. Let's try comment #8 first to see which part needs fixes.

Comment 10

[Ethan Tseng [:ethan]]

I pulled the latest mozilla-central and Gaia master. This bug disappears.
Apparently it was already fixed by some other bug.