Closed Bug 989272 Opened 10 years ago Closed 10 years ago

FPS and TTL monitors shouldn't depend on the Developer HUD being active.

Categories

(Firefox OS Graveyard :: Developer Tools, defect)

All
Gonk (Firefox OS)
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: janx, Assigned: janx)

References

Details

Attachments

(1 file)

46 bytes, text/x-github-pull-request
vingtetun
: review+
Details | Review
Currently, the FPS and TTL monitor widgets of the Developer HUD are different from the other widgets, because they were there before and use different code paths to work.

This means that they actually don't need the frame instrumentation added by the Developer HUD, and as of now they do not hide when the main Developer HUD toggle is switched off.

They should either be integrated with the rest of the widgets, or their settings should not be disabled when the Developer HUD is turned off (either they should stay active, or be moved out of the HUD menu entirely).
Assignee: nobody → janx
Status: NEW → ASSIGNED
Attached file github pull request
Evelyn, could you please take a look? In the Developer HUD, I prevented the foreign FPS and TTL settings from being disabled. That way they can still be used even when the rest of the Developer HUD is disabled.
Attachment #8399293 - Flags: review?(ehung)
Comment on attachment 8399293 [details] [review]
github pull request

Maybe Evelyn is busy, Vivien could you please have a look?
Attachment #8399293 - Flags: review?(ehung) → review?(21)
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Component: Gaia::Settings → Developer Tools
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: