989288 - Firefox Addons SDK is not receving any events from windows opened via window.open

Status: RESOLVED FIXED

(Add-on SDK Graveyard :: General, defect, P1)

Description

[alagiri buddhar]

User Agent: Mozilla/5.0 (Windows NT 6.1) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/33.0.1750.154 Safari/537.36

Steps to reproduce:

1.created a sample html page which contains window.open
2.I created an Add-on SDK to listen window,tab and page-mod events
3.Check for window , tab and page-mod events for newly opened window using window.open.


Actual results:

Events in the newly created window via window.open is not listened from add-on sdk


Expected results:

We should be able to receive window , tab and page-mod events from newly created window.

Comment 1

[Ben McCann]

Still the case in Firefox 40. We're receiving absolutely no events from these windows.

Comment 2

[Matthias Steinkogler]

Additionally, I noticed the following behaviors:

1) When attaching a content script via the onAttach method of a pagemod config, when the specified callback function is called the worker delivered via its parameter does not have a tab (worker.tab is undefined)

2) No events are fired when the window is opened, but as soon as its _closed_, the following events are immediately received:
browserTabs.on("open")
browserTabs.on("close")
browserWindows.on("close")

Maybe that helps.

Comment 3

[Jacobo Aragunde Pérez]

Attachment: Pull request with a fix and tests for this bug.

Comment 4

[Jacobo Aragunde Pérez]

The pull request on bug #939496, closely related with this one, has been updated. Please review, thanks!

Comment 5

[Jacobo Aragunde Pérez]

The pull request for this bug has been updated, reviews are welcome. If the preferred way to contribute code has changed lately, I can send the patch by any other means. Thanks!

Comment 6

[Jacobo Aragunde Pérez]

Any chance to get the patch reviewed? Thanks in advance!

Comment 7

[Jordan Santell [:jsantell] [@jsantell]]

Comment on attachment 8648120 [details] [review]
Pull request with a fix and tests for this bug.

From r? comments in https://github.com/mozilla/addon-sdk/pull/2030#issuecomment-163801394

Comment 8

[Jacobo Aragunde Pérez]

Hi, any chance to get the patch reviewed? Thanks!

Comment 9

[Ben McCann]

Can we please get this reviewed? Thanks!

Comment 10

[Jordan Santell [:jsantell] [@jsantell]]

Ping Matteo for r?

Comment 11

[Matteo Ferretti [:zer0] [:matteo]]

Comment on attachment 8648120 [details] [review]
Pull request with a fix and tests for this bug.

Sorry for the long waiting. Looks good to me, r+. I ran the test suite against this patch and seems there are no failures, at least locally.

Comment 12

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/46fd541b3440

Comment 13

[Dave Townsend [:mossop]]

(In reply to Pulsebot from comment #12)
> https://hg.mozilla.org/integration/fx-team/rev/46fd541b3440

This was reviewed in bug 993015.

Comment 14

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/46fd541b3440