989459 - [B2G] [WAP Push] Expired WAP Pushes can still be received by the device

Status: RESOLVED WORKSFORME

(Firefox OS Graveyard :: Gaia::Wappush, defect)

Description

[Chris Kreinbring [:CKreinbring]]

Attachment: Log of receiving expired WAP Push

Description:
WAP Push messages sent to the device that have already expired can still be received by the device.

Repro Steps:
1) Updated Buri to Build ID: 20140326000201
2) Select Settings, then Messaging Settings, then turn on the WAP Push option.
3) From the NowSMS app on the PC, send a WAP Push message with the destination number, WAP URL, SI ID, and an SI Expires date set to the past.
4) Select Submit and watch for the WAP Push message to appear on the device.

Actual:
The WAP Push message appears on the device.

Expected:
The message never appears on the phone since it is already expired.

Environmental Variables
Device: Buri 1.4 mozilla RIL
Build ID: 20140326000201
Gecko: https://hg.mozilla.org/releases/mozilla-aurora/rev/4889124accfa
Gaia: 7e705dd4718d528974d99ac31866318d7e201152
Platform Version: 30.0a2
Firmware Version: V1.2-device.cfg

Notes:
Repro frequency: 100%
Link to failed test case: https://moztrap.mozilla.org/manage/cases/?filter-id=9373
See attached logcat logs

Comment 1

[Chris Kreinbring [:CKreinbring]]

Repros on Buri 1.3 mozilla RIL.

Build ID: 20140326004002
Gecko: https://hg.mozilla.org/releases/mozilla-b2g28_v1_3/rev/ba97efb0da4b
Gaia: 812838ad0fabf51fa14435af562ddac6d26fa936
Platform Version: 28.0
Firmware Version: V1.2-device.cfg

Comment 2

[Gabriele Svelto [:gsvelto]]

Attachment: Dump message

Strange, I've tested this on the emulator with the following message and it seems to work correctly:

sender: [phone]
contentType: text/vnd.wap.si
content: <si><indication href=\"http://www.xyz.com/email/123/abc.wml\" created=\"1999-06-25T15:23:15Z\" si-expires=\"1999-06-30T00:00:00Z\">You have 4 new emails</indication></si>

Can you please test this again on master with this patch applied and post the logcat output? It should contain a message that says:

WAP Push message received: { ... }

Note that you'll need the 'debug.gaia.enabled' preference set to true for this to work.

Comment 3

[Jason Smith [:jsmith]]

Gabriele - Can you put this patch in a github branch? That will help QA out in doing the testing request you need done here.

Comment 4

[Gabriele Svelto [:gsvelto]]

This branch can be used for testing: https://github.com/gabrielesvelto/gaia/tree/bug-989459-dump

I've modified it so that you don't need to set any preferences, the incoming message will be dump to the logcat unconditionally.

Comment 5

[Chris Kreinbring [:CKreinbring]]

Unable to repro on today's Buri 1.4 mozilla RIL.  The WAP push messages do not appear if the expire time is set to the past.  Resolving as Worksforme for now.

Build ID: 20140404000202
Gecko: https://hg.mozilla.org/releases/mozilla-aurora/rev/3186bbc50050
Gaia: b4f3b84ec68233a99fd5865c15cfe28aebe26531
Platform Version: 30.0a2
Firmware Version: V1.2-device.cfg