Closed Bug 989479 Opened 7 years ago Closed 7 years ago

InContent preferences treats [disabled=false] as disabled state

Categories

(Firefox :: Preferences, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
Firefox 31

People

(Reporter: ntim, Assigned: ntim)

References

Details

Attachments

(1 file)

Screenshot, which also explains the solution to the issue : http://images.devs-on.net/Image/agCctCaihT96Qrd7-Region.png

Gonna make a patch for this.
Blocks: 738796
Attached patch Patch v1Splinter Review
Attachment #8398759 - Flags: review?(jaws)
Jared, if you don't know what this is about, check the selected inspector element in the screenshot. It has disabled="false". And the CSS for disabled state applies to it.

The [disabled="true"] selector is used in most of Firefox's CSS files, so it'd be nice to stay consistent.
Richard, do you think you can review this ? Or should I leave this to Jared ?
Flags: needinfo?(richard.marti)
I'm not doing Fx reviews but the patch is looking good.
Flags: needinfo?(richard.marti)
Attachment #8398759 - Flags: review?(jaws) → review+
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/775acd446f8f
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 31
Does this need tests?
Flags: in-testsuite?
I don't think so. Adding reftests for this doesn't seem needed.
Flags: in-testsuite? → in-testsuite-
QA Whiteboard: [qa-]
Component: Untriaged → Preferences
You need to log in before you can comment on or make changes to this bug.