Closed
Bug 989479
Opened 11 years ago
Closed 11 years ago
InContent preferences treats [disabled=false] as disabled state
Categories
(Firefox :: Settings UI, defect)
Firefox
Settings UI
Tracking
()
RESOLVED
FIXED
Firefox 31
People
(Reporter: ntim, Assigned: ntim)
References
Details
Attachments
(1 file)
|
3.37 KB,
patch
|
jaws
:
review+
|
Details | Diff | Splinter Review |
Screenshot, which also explains the solution to the issue : http://images.devs-on.net/Image/agCctCaihT96Qrd7-Region.png
Gonna make a patch for this.
|
Assignee | |
Comment 1•11 years ago
|
||
Attachment #8398759 -
Flags: review?(jaws)
|
|
Assignee | |
Comment 2•11 years ago
|
||
Jared, if you don't know what this is about, check the selected inspector element in the screenshot. It has disabled="false". And the CSS for disabled state applies to it.
The [disabled="true"] selector is used in most of Firefox's CSS files, so it'd be nice to stay consistent.
|
|
Assignee | |
Comment 3•11 years ago
|
||
Richard, do you think you can review this ? Or should I leave this to Jared ?
Flags: needinfo?(richard.marti)
|
||
Comment 4•11 years ago
|
||
I'm not doing Fx reviews but the patch is looking good.
Flags: needinfo?(richard.marti)
|
||
Updated•11 years ago
|
Attachment #8398759 -
Flags: review?(jaws) → review+
|
|
Assignee | |
Updated•11 years ago
|
Keywords: checkin-needed
Keywords: checkin-needed
Whiteboard: [fixed-in-fx-team]
|
||
Comment 6•11 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 31
|
|
Assignee | |
Comment 8•10 years ago
|
||
I don't think so. Adding reftests for this doesn't seem needed.
Flags: in-testsuite? → in-testsuite-
You need to log in
before you can comment on or make changes to this bug.
Description
•