Closed
Bug 989538
Opened 11 years ago
Closed 11 years ago
[DeviceStorage] GetDefaultStorageName should always assign to the returned storageName
Categories
(Core :: DOM: Device Interfaces, defect)
Tracking
()
RESOLVED
FIXED
1.4 S5 (11apr)
People
(Reporter: dhylands, Assigned: dhylands)
Details
(Whiteboard: [fxos:media])
Attachments
(1 file, 1 obsolete file)
|
941 bytes,
patch
|
janv
:
review+
|
Details | Diff | Splinter Review |
GetDefaultStorageName should ensure that the returned storageName is always assigned, to cover the case where there are no volumes (as happens on b2g-desktop).
Currently, in the case where there are no volumes, it returns whatever storageName was passed in (which is typically empty).
|
Assignee | |
Comment 1•11 years ago
|
||
A very small review.
Attachment #8398829 -
Flags: review?(Jan.Varga)
|
|
Assignee | |
Comment 2•11 years ago
|
||
Whoops. Accidentally got an extra line deleted that wasn't supposed to be. This patch fixes that.
Attachment #8398829 -
Attachment is obsolete: true
Attachment #8398829 -
Flags: review?(Jan.Varga)
Attachment #8398830 -
Flags: review?(Jan.Varga)
|
||
Updated•11 years ago
|
Attachment #8398830 -
Flags: review?(Jan.Varga) → review+
|
|
Assignee | |
Comment 3•11 years ago
|
||
|
|
Assignee | |
Updated•11 years ago
|
Whiteboard: [fxos:media]
|
|
Assignee | |
Updated•11 years ago
|
Target Milestone: --- → 1.4 S5 (11apr)
|
||
Comment 4•11 years ago
|
||
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•