Closed Bug 989538 Opened 6 years ago Closed 6 years ago

[DeviceStorage] GetDefaultStorageName should always assign to the returned storageName

Categories

(Core :: DOM: Device Interfaces, defect)

x86_64
Linux
defect
Not set

Tracking

()

RESOLVED FIXED
1.4 S5 (11apr)

People

(Reporter: dhylands, Assigned: dhylands)

Details

(Whiteboard: [fxos:media])

Attachments

(1 file, 1 obsolete file)

GetDefaultStorageName should ensure that the returned storageName is always assigned, to cover the case where there are no volumes (as happens on b2g-desktop).

Currently, in the case where there are no volumes, it returns whatever storageName was passed in (which is typically empty).
A very small review.
Attachment #8398829 - Flags: review?(Jan.Varga)
Whoops. Accidentally got an extra line deleted that wasn't supposed to be. This patch fixes that.
Attachment #8398829 - Attachment is obsolete: true
Attachment #8398829 - Flags: review?(Jan.Varga)
Attachment #8398830 - Flags: review?(Jan.Varga)
Attachment #8398830 - Flags: review?(Jan.Varga) → review+
Whiteboard: [fxos:media]
Target Milestone: --- → 1.4 S5 (11apr)
https://hg.mozilla.org/mozilla-central/rev/57d40d0a0aba
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.