989667 - Add writes of recovery meta-data to MResumePoint.

Status: RESOLVED FIXED

(Core :: JavaScript Engine: JIT, defect)

Description

[Nicolas B. Pierron [:nbp]]

Currently a resume point is the structure which is used to represent a frame.  Thus it is logical that a resume point should encode the structure which is unique to the MResumePoint instead of delegating this task to the RecoverWriter.

The RecoverWriter should provide a its CompactBufferWriter to the write function of the MResumePoint.

Comment 1

[Nicolas B. Pierron [:nbp]]

Attachment: Add writes of recovery meta-data to the MResumePoint.

Comment 2

[Nicolas B. Pierron [:nbp]]

Comment on attachment 8399025 [details] [diff] [review]
Add writes of recovery meta-data to the MResumePoint.

Review of attachment 8399025 [details] [diff] [review]:
-----------------------------------------------------------------

Jan, feel free to steal the review if you have more time than Hannes.

Comment 3

[Hannes Verschore [:h4writer]]

Comment on attachment 8399025 [details] [diff] [review]
Add writes of recovery meta-data to the MResumePoint.

Review of attachment 8399025 [details] [diff] [review]:
-----------------------------------------------------------------

We decided on IRC it might be good to remove "writeRecoverData" and create a "visitXXX" out of this on a class RecoverDataGenerator (or something). This is to remove lowering/generating/visiting functions on the MIR structure. This would be similar to how CodeGenerator.cpp and Lowering.cpp works. I think this can go in Recover.cpp.
On IRC we agreed it would be ok to do this in a follow-up bug.

Note: We also were busy about creating "RIR.cpp/h" when the "Recover Instructions" finally get added. Though this is probably for the review of when we finally get that :D.

Comment 4

[Nicolas B. Pierron [:nbp]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/3bd8dc58dcf3

Comment 5

[Ryan VanderMeulen [:RyanVM]]

Backed out for B2G bustage in the push.
https://hg.mozilla.org/integration/mozilla-inbound/rev/c4d1adee6057

https://tbpl.mozilla.org/php/getParsedLog.php?id=37290188&tree=Mozilla-Inbound

Comment 6

[Nicolas B. Pierron [:nbp]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/4785fcedc937

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/4785fcedc937