989682 - Add usage telemetry to geolocation

Status: RESOLVED FIXED

(Core :: DOM: Geolocation, defect)

Description

[Doug Turner (:dougt)]

We would like to know the accuracy reported to our using by our geolocation implementations as well as what users see errors.

Comment 1

[Doug Turner (:dougt)]

Attachment: 0001-Add-telemetry-data-to-geolocation.patch

Comment 2

[Josh Matthews [:jdm]]

Comment on attachment 8399007 [details] [diff] [review]
0001-Add-telemetry-data-to-geolocation.patch

Review of attachment 8399007 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/src/geolocation/nsGeolocation.cpp
@@ +1152,5 @@
> +      coords->GetAccuracy(&accuracy);
> +      mozilla::Telemetry::Accumulate(mozilla::Telemetry::GEOLOCATION_ACCURACY, accuracy);
> +    }
> +  }
> +  

Nit: whitespace

@@ +1186,5 @@
>      return NS_OK;
>    }
>  
> +  mozilla::Telemetry::Accumulate(mozilla::Telemetry::GEOLOCATION_ERROR, true);
> +    

Nit: whitespace

::: toolkit/components/telemetry/Histograms.json
@@ +299,5 @@
> +  "GEOLOCATION_ACCURACY": {
> +    "expires_in_version": "never",
> +    "kind": "linear",
> +    "high": "18000",
> +    "n_buckets": 200,  

Nit: whitespace

@@ +305,5 @@
> +  },
> +  "GEOLOCATION_ERROR": {
> +    "expires_in_version": "never",
> +    "kind": "flag",
> +    "description": "Has seen location error"

Is this only a boolean value per session? Is that actually useful at all, since we don't know how many times geolocation was attempted, nor how long the session lasted? Furthermore, this is going to bite us for users of many distro builds (such as Ubuntu), which don't include an API key.

Comment 3

[Doug Turner (:dougt)]

> Is this only a boolean value per session?

This is useful -- I can see (via google dashbash) the total number of failures for all requests.  What I want to see is the number of sessions that have an error (don't care how many errors they have)

> Furthermore, this is going to bite us for users of many distro builds (such as Ubuntu), which don't include an API key.

We're going to find out.  If it's too noisy, we'll do something like only track builds that have the API key set.

Comment 4

[Josh Matthews [:jdm]]

Comment on attachment 8399007 [details] [diff] [review]
0001-Add-telemetry-data-to-geolocation.patch

Your answers make sense to me.

Comment 5

[Doug Turner (:dougt)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/4c7030be9a56

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/4c7030be9a56