Closed
Bug 989682
Opened 11 years ago
Closed 11 years ago
Add usage telemetry to geolocation
Categories
(Core :: DOM: Geolocation, defect)
Core
DOM: Geolocation
Tracking
()
RESOLVED
FIXED
mozilla31
People
(Reporter: dougt, Assigned: dougt)
Details
Attachments
(1 file)
2.40 KB,
patch
|
jdm
:
review+
|
Details | Diff | Splinter Review |
We would like to know the accuracy reported to our using by our geolocation implementations as well as what users see errors.
Assignee | ||
Updated•11 years ago
|
Assignee: nobody → dougt
Assignee | ||
Comment 1•11 years ago
|
||
Attachment #8399007 -
Flags: review?(josh)
Comment 2•11 years ago
|
||
Comment on attachment 8399007 [details] [diff] [review]
0001-Add-telemetry-data-to-geolocation.patch
Review of attachment 8399007 [details] [diff] [review]:
-----------------------------------------------------------------
::: dom/src/geolocation/nsGeolocation.cpp
@@ +1152,5 @@
> + coords->GetAccuracy(&accuracy);
> + mozilla::Telemetry::Accumulate(mozilla::Telemetry::GEOLOCATION_ACCURACY, accuracy);
> + }
> + }
> +
Nit: whitespace
@@ +1186,5 @@
> return NS_OK;
> }
>
> + mozilla::Telemetry::Accumulate(mozilla::Telemetry::GEOLOCATION_ERROR, true);
> +
Nit: whitespace
::: toolkit/components/telemetry/Histograms.json
@@ +299,5 @@
> + "GEOLOCATION_ACCURACY": {
> + "expires_in_version": "never",
> + "kind": "linear",
> + "high": "18000",
> + "n_buckets": 200,
Nit: whitespace
@@ +305,5 @@
> + },
> + "GEOLOCATION_ERROR": {
> + "expires_in_version": "never",
> + "kind": "flag",
> + "description": "Has seen location error"
Is this only a boolean value per session? Is that actually useful at all, since we don't know how many times geolocation was attempted, nor how long the session lasted? Furthermore, this is going to bite us for users of many distro builds (such as Ubuntu), which don't include an API key.
Attachment #8399007 -
Flags: review?(josh)
Assignee | ||
Comment 3•11 years ago
|
||
> Is this only a boolean value per session?
This is useful -- I can see (via google dashbash) the total number of failures for all requests. What I want to see is the number of sessions that have an error (don't care how many errors they have)
> Furthermore, this is going to bite us for users of many distro builds (such as Ubuntu), which don't include an API key.
We're going to find out. If it's too noisy, we'll do something like only track builds that have the API key set.
Comment 4•11 years ago
|
||
Comment on attachment 8399007 [details] [diff] [review]
0001-Add-telemetry-data-to-geolocation.patch
Your answers make sense to me.
Attachment #8399007 -
Flags: review+
Assignee | ||
Comment 5•11 years ago
|
||
Comment 6•11 years ago
|
||
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla31
You need to log in
before you can comment on or make changes to this bug.
Description
•