989708 - CanvasRenderingContext2D.cpp:2428:8: error: variable ‘isDescendant’ set but not used [-Werror=unused-but-set-variable]

Status: RESOLVED FIXED

(Core :: Graphics: Canvas2D, defect)

Description

[Daniel Holbert [:dholbert]]

GCC 4.8 build warning in --disable-accessibility builds, treated as error if you build with --enable-warnings-as-errors:
{
content/canvas/src/CanvasRenderingContext2D.cpp:2428:8: error: variable ‘isDescendant’ set but not used [-Werror=unused-but-set-variable]
}

This variable was added in
  http://hg.mozilla.org/mozilla-central/rev/fc089133d229
for bug 966591, and then its usages were #ifdef-guarded in a followup (which I pushed, because they fixed my compile issues at the time per bug 966591 comment 106). Not sure if something changed between then and now, or if I simply wasn't using GCC 4.8 at that time, but in any case, I'm hitting this issue now with GCC 4.8.

Comment 1

[Daniel Holbert [:dholbert]]

(For the record, the #ifdef guarding followup was
 https://hg.mozilla.org/integration/mozilla-inbound/rev/5d9a2c52728a
)

Comment 2

[:Cykesiopka]

Attachment: bug989708_v1.patch

This fixes --disable-accessibility builds for me (GCC 4.8).

Comment 3

[Daniel Holbert [:dholbert]]

Thanks for the patch! I tweaked the commit message to add reviewer (and to make it a little more specific), and landed:  https://hg.mozilla.org/integration/mozilla-inbound/rev/ab80c7351c88

Comment 4

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/ab80c7351c88