989729 - [Tarako][Dailer] Cannot unlock screen when call in background

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::System::Lockscreen, defect)

Description

[Bingqing Li]

Environment:
-------------------
Gaia 14ef4fcdf9199f04f7678755c917dc77f51e13ba
Gecko https://hg.mozilla.org/releases/mozilla-b2g28_v1_3t/rev/b574a7967338
BuildID 20140329004002
Version 28.1


Steps to reproduce:
--------------------
1. Lock the screen of the test device 
2. Make a call to the test device
3. Answer the call
4. Press the Home key to switch the call in background
5. Try to unlock the screen

Actual results:
---------------------
Cannot unlock the screen because no unlock button there.

Comment 1

[yang.zhao]

caused by the following commit:


commit e2b1019efe2d6e1fd8fdff337d2187826f53f688
Author: Greg Weng <[e-mail]>
Date:   Mon Mar 17 11:33:49 2014 +0800

    Bug 982530 - [tarako] incoming call with lock screen overlapped for a while

Comment 2

[Greg Weng [:snowmantw][:gweng][:λ]]

What do you mean to

3. Answer the call
4. Press the Home key to switch the call in background

Is this means you have already answered the phone (slide the incoming lockscreen to the right),
and then pressed the home key?

On my device, it would return to homescreen as the normal behavior, and would NOT return to lockscreen, so the step

5. Try to unlock the screen

is no need to follow (there is no lockscreen anymore, so no need to unlock).

Comment 3

[yang.zhao]

(In reply to Greg Weng [:snowmantw][:gweng][:λ] from comment #2)
> What do you mean to
> 
> 3. Answer the call
> 4. Press the Home key to switch the call in background
> 
> Is this means you have already answered the phone (slide the incoming
> lockscreen to the right),
> and then pressed the home key?
> 
Yeah,answer the phone,then press Home button.Nothing in the homescreen.I'll attach a picture later.
Please use the latest version to verify.there is a "disable" class in <div id="lockscreen">,so the screen "<div id='lockscreen-disabled-cover'> is shown when press the home button.
> On my device, it would return to homescreen as the normal behavior, and
> would NOT return to lockscreen, so the step
> 
> 5. Try to unlock the screen
> 
> is no need to follow (there is no lockscreen anymore, so no need to unlock).

Comment 4

[yang.zhao]

Attachment: 2014-03-31-16-08-54.png

This is the screenshot after answering the phone,and press the Home button.

Comment 5

[Bingqing Li]

(In reply to Greg Weng [:snowmantw][:gweng][:λ] from comment #2)

> On my device, it would return to homescreen as the normal behavior, and
> would NOT return to lockscreen, so the step
> 
> 5. Try to unlock the screen
> 
> is no need to follow (there is no lockscreen anymore, so no need to unlock).
>
If the expected result is like what you mentioned in comment #2, this bug should be like this:

Summary: Fail to return homescreen when switch the call into background

Steps to reproduce:
--------------------
1. Lock the screen of the test device 
2. Make a call to the test device
3. Answer the call
4. Press the Home key to switch the call into background

Actual results:
---------------------
There is no icon on the screen, and only the wallpaper there.

Comment 6

[Greg Weng [:snowmantw][:gweng][:λ]]

Thanks for more information. I'll investigate this according to it.

Comment 7

[yang.zhao]

(In reply to Bingqing Li from comment #5)
> (In reply to Greg Weng [:snowmantw][:gweng][:λ] from comment #2)
> 
> > On my device, it would return to homescreen as the normal behavior, and
> > would NOT return to lockscreen, so the step
> > 
> > 5. Try to unlock the screen
> > 
> > is no need to follow (there is no lockscreen anymore, so no need to unlock).
> >
> If the expected result is like what you mentioned in comment #2, this bug
> should be like this:
> 
> Summary: Fail to return homescreen when switch the call into background
> 
> Steps to reproduce:
> --------------------
> 1. Lock the screen of the test device 
> 2. Make a call to the test device
> 3. Answer the call
> 4. Press the Home key to switch the call into background
> 
> Actual results:
> ---------------------
> There is no icon on the screen, and only the wallpaper there.

Our tester thinks that it hasn't been unlock when you answer the phone,so there should be the lockscreen under the call.But I don't know what it should be like.I think you should ask your PD to affirm it in production defination specification.

Comment 8

[Joe Cheng [:jcheng] (please needinfo)]

triage: this is a 1.3t+ regression
to Greg for now thanks

Comment 9

[Greg Weng [:snowmantw][:gweng][:λ]]

I remember that whether we need to unlock twice is a continuing problem... someone reported that they need to unlock twice when incoming call comes, and the others think the incoming unlocking is different from the "real" unlocking. So I'll ask UX while I'm solving this bug.

Comment 10

[Greg Weng [:snowmantw][:gweng][:λ]]

UX Carrie has confirmed that we should come back to lockscreen, even this would let user unlock twice. Because user may not want to unlock phone after accepted the incoming call, and put it back to the pocket immediately, without the lockscreen's protection.

And I had patched this. I'll attach it later.

Comment 11

[Greg Weng [:snowmantw][:gweng][:λ]]

Attachment: solved.mp4

I've attached the video to show the lockscreen now would display normally. I'll submit the patch later.

Comment 12

[Greg Weng [:snowmantw][:gweng][:λ]]

Attachment: Patch

Solved the issue as the video shows.
Again, this patch may differs from the master. But I don't think I need to fire a follow-up bug this time, because I can patch the master without this issue.

Comment 13

[Greg Weng [:snowmantw][:gweng][:λ]]

Travis now is green. Waiting for reviewing.

https://travis-ci.org/mozilla-b2g/gaia/builds/21927808

Comment 14

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Comment on attachment 8399304 [details] [review]
Patch

Can we add some test cases?

Comment 15

[Greg Weng [:snowmantw][:gweng][:λ]]

Travis is green:

https://travis-ci.org/mozilla-b2g/gaia/builds/21927808

We may provide some integration test (because this is a visual issue), but may not happen so fast.
So I would land the patch first, and to see to add it while I solve the related issue on master.

Comment 16

[Greg Weng [:snowmantw][:gweng][:λ]]

v1.3t: https://github.com/mozilla-b2g/gaia/commit/578fdccea89a88b417d296f8cf20b39099d44be4

Comment 17

[Derek Harris [:DerekH] - Dont need info. Last day 6/5/15]

Verified fixed in todays Tarako build

1.3t Environmental Variables:
Device: Tarako 1.3t
BuildID: 20140501014002
Gaia: d26a776beae0070b0032248a2ce482bbe6321a6d
Gecko: e90f4b655511
Version: 28.1
Firmware Version: sp6821

Comment 18

[Roland Kunkel [:RolandK]]

Verified in comment #17, changing status of bug.