Closed Bug 989796 Opened 6 years ago Closed 6 years ago

[UX] Add »Undo close tab« to relevant menus

Categories

(Firefox :: Menus, defect)

27 Branch
x86
macOS
defect
Not set

Tracking

()

VERIFIED FIXED

People

(Reporter: phlsa, Assigned: jboriss)

References

Details

(Whiteboard: [ux] [diamond] [mentor=bwinton] p=3 s=it-32c-31a-30b.2 [qa-])

Attachments

(1 file, 1 obsolete file)

We currently have an entry »Undo close tab« in the context menu of tabs. However, that is not necessarily the most logical place for this item.

We should therefore also add it to two other menus as well:
1. The context menu of the empty area in the tab strip
So that should read something like this:

Undo close tab
--------------
Move to menu
...


2. The dropdown menu at the end of the tab strip (which only appears if tabs are overflowing)

Undo close tab
--------------
Tab Groups
--------------
[Tab name]
...
Blocks: fxdesktopbacklog
No longer blocks: fxdesktoptriage
Summary: Add »Undo close tab« to relevant menus → [UX] Add »Undo close tab« to relevant menus
Whiteboard: [ux] p=0
I don't think this needs any more UX work. I can post a quick mockup here if the ASCII diagrams aren't clear enough, but the design work is done.
Summary: [UX] Add »Undo close tab« to relevant menus → Add »Undo close tab« to relevant menus
No longer blocks: fxdesktopbacklog
Flags: firefox-backlog+
Following the triage meetings, this remains unassigned. Bwinton has volunteered to mentor, flagging as a diamond bug.
Flags: needinfo?(philipp)
Whiteboard: [ux] p=0 → [ux] p=0 [diamond] [mentor=bwinton]
For my reference later, the tab strip context menu seems to be #toolbar-context-menu (which may need to change), and the dropdown menu seems to be #alltabs-popup (which should be fine as is).
Whiteboard: [ux] p=0 [diamond] [mentor=bwinton] → [ux] [diamond] [mentor=bwinton] p=3
This looks like a good way to move forward.
Mike, I'm not sure what your needinfo was about – just flag me again if I can help with anything :)
Flags: needinfo?(philipp)
Summary: Add »Undo close tab« to relevant menus → [UX] Add »Undo close tab« to relevant menus
Assignee: nobody → jboriss
Status: NEW → ASSIGNED
Whiteboard: [ux] [diamond] [mentor=bwinton] p=3 → [ux] [diamond] [mentor=bwinton] p=3 s=it-32c-31a-30b.2 [qa-]
Attached are mockups showing the two places in Firefox’s UI where “undo close tab” should be added:

1. Context menu of the empty area in the tab strip. 

The rationale here stems from the fact that currently, users can undo a closed tab in a tab, but not right beside it.  This means there are some places in the menu bar that users can undo a tab closure from and other they cannot, and with Australis making background tabs more subtle, the difference is currently fairly arbitrary.  After all, neither a tab or the menu is the closed tab in question.

The option should be added to the top set under “Remove from Toolbar.”  This allows “Customize” to still be the most obvious bottom target, which is important since it’s the place a user right-clicking the toolbar will most likely find helpful.

2. Overflow tab menu

The rationale here is that this menu serves as a tab access point, including a link to launch tab groups.  If this menu is truly for tab management, undoing what was previously closed makes sense as an action here.  

Everything in this menu has an icon, so this needs one too.  We can make a new one, but for now let’s use the New Tab icon (http://mxr.mozilla.org/mozilla-central/source/browser/themes/osx/Toolbar.png).  That and reload are the two most similar, but reload implies that action will happen to the current page while New Tab correctly implies an additional tab will be opened.
Thanks Boriss!
Since we are specifically talking about the empty area in the tab strip, wouldn't it make sense to get rid of the two inactive items (Move to menu, Remove from toolbar) in that context menu altogether?
Just for the empty space, not for widgets placed in the tab strip…
(In reply to Philipp Sackl [:phlsa] from comment #6)
> Thanks Boriss!
> Since we are specifically talking about the empty area in the tab strip,
> wouldn't it make sense to get rid of the two inactive items (Move to menu,
> Remove from toolbar) in that context menu altogether?
> Just for the empty space, not for widgets placed in the tab strip…

Yes, it would make sense to get rid of them!  I'll mention that in the followup bug - it may be another bug is needed to cover that.

I spoke with Bwinton, who pointed out that "undo close tab" may be different enough from "move toolbar" options (in 1c) that a separator may be a good idea.  Of course, Comment 6 correctly points out that these would seemingly never be defaulted on anyway.  Given this feedback, I'm going to slightly adjust the design to take the "global" tab options and add them to the context menu for the toolbar.  After all, if the rationale of modal errors from different options is true for closing the last tab, it's true of the other tab-related options also.  This would leave only tab-specific actions as only viewable on tabs themselves.  

Thanks for the feedback, Philipp and Blake. I'll post a followup mockup.
Followup implementation bug filed: bug 1014313
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Status: RESOLVED → VERIFIED
Blocks: 1014313
You need to log in before you can comment on or make changes to this bug.