989819 - [gtk3] Location bar is smaller than intended height

Status: RESOLVED DUPLICATE of bug 989466

(Core :: Widget: Gtk, defect)

Description

[Amit Prakash Ambasta]

Attachment: Screenshot from 2014-03-31 02:54:33.png

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Firefox/31.0 (Beta/Release)
Build ID: 20140331021500

Steps to reproduce:

Build firefox from trunk with gtk3 enabled.


Actual results:

The height of location bar seems to be a little smaller than intended. Selecting the location bar leads to an incomplete border around the location bar with the top border missing/cut-off

Comment 1

[Amit Prakash Ambasta]

Attachment: Screenshot from 2014-03-31 02:55:49.png

Comment 3

[Martin Stránský [:stransky] (ni? me) (PTO, back on Feb 17)]

Well, this is Gtk3 only. It works fine with Gtk2 toolkit.

Comment 4

[Martin Stránský [:stransky] (ni? me) (PTO, back on Feb 17)]

Dão, how are those element painted? The location/search bars are no longer GtkEntry elements.

Comment 5

[Amit Prakash Ambasta]

Hi,

I mentioned it being GTK3 only in the bug title

Comment 6

[Martin Stránský [:stransky] (ni? me) (PTO, back on Feb 17)]

Actually it's dupe of Bug 978172 - the borders have bad (transparent) colors now.

Comment 7

[:Gijs (he/him)]

(In reply to Martin Stránský from comment #6)
> Actually it's dupe of Bug 978172 - the borders have bad (transparent) colors
> now.
> 
> *** This bug has been marked as a duplicate of bug 978172 ***

Huh? I think Dão was right, and this is a dupe of bug 989466. Bug 978172 is about doorhangers, this is about the location bar (which isn't a doorhanger). Can you clarify?

Comment 8

[Martin Stránský [:stransky] (ni? me) (PTO, back on Feb 17)]

IMHO The toolbar looks smaller because is missing borders which are transparent. With a patch from Bug 989466 the toolbar looks ok. But frankly I don't measure it pixel by pixel - so it may on may not be smaller. But looking at the attached screenshot the primary issue here are the missing borders.

Comment 9

[:Gijs (he/him)]

(In reply to Martin Stránský from comment #8)
> IMHO The toolbar looks smaller because is missing borders which are
> transparent.

The urlbar border isn't transparent, it's clipped. C.f. bug 989466 comment 5.

> With a patch from Bug 989466 the toolbar looks ok. But frankly
> I don't measure it pixel by pixel - so it may on may not be smaller. But
> looking at the attached screenshot the primary issue here are the missing
> borders.

Right, but then it's really a dupe of 989466, which is specifically about this border, and not a dupe of the doorhanger bug.

Comment 10

[Martin Stránský [:stransky] (ni? me) (PTO, back on Feb 17)]

Sorry, with a patch from Bug 978172 the URL bar looks ok. Bug 989466 does not have any patch. Sorry for the confusion. But honestly I don't care as long as this one is marked as a dupe :)