989855 - mach mochitest-plain doesn't understand symlinks

Status: NEW

(Testing :: Mochitest, defect)

Description

[Karl Tomlinson (:karlt)]

+++ This bug was initially created as a clone of Bug #911646 +++

% ./mach mochitest-plain content/media/webaudio/test

AssertionError

  File "/home/karl/moz/dev/testing/mochitest/mach_commands.py", line 578, in run_mochitest_plain
    return self.run_mochitest(test_paths, 'plain', **kwargs)
  File "/home/karl/moz/dev/testing/mochitest/mach_commands.py", line 633, in run_mochitest
    test_paths=test_paths, suite=flavor, **kwargs)
  File "/home/karl/moz/dev/testing/mochitest/mach_commands.py", line 370, in run_desktop_test
    result = runner.runTests(options)
  File "/home/karl/moz/dev/obj/_tests/testing/mochitest/runtests.py", line 1111, in runTests
    testURL = self.buildTestPath(options)
  File "/home/karl/moz/dev/obj/_tests/testing/mochitest/runtests.py", line 471, in buildTestPath
    assert pathAbs.startswith(testRootAbs)

Comment 1

[Karl Tomlinson (:karlt)]

TEST_PATH=content/media/webaudio/test make -C obj/ mochitest-plain
behaves as expected.

Comment 2

[(not currently active) Ted Mielczarek]

Where's the symlink in this setup?

Comment 3

[Karl Tomlinson (:karlt)]

% ls -l obj
lrwxrwxrwx 1 karl users 19 Jun 29  2013 obj -> /mnt/sda11/karl/obj
% grep obj .mozconfig
mk_add_options MOZ_OBJDIR=@TOPSRCDIR@/obj

Comment 4

[Gregory Szorc [:gps]]

I think you'll be much happier if you teach your mozconfig about the real path and use the symlink only for convenience.

There is path resolution code everywhere in the tree. Sadly, you can't count on symlinks "just working" everywhere, as convenient as that would be. (You don't have to remind me this is a regression.)

I apologize for the inconvenience.

Comment 5

[Karl Tomlinson (:karlt)]

(In reply to Gregory Szorc [:gps] from comment #4)
> I think you'll be much happier if you teach your mozconfig about the real
> path and use the symlink only for convenience.

That seems to work, thanks.