989909 - vcard Export / Import does not deal with birthday and anniversary

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Contacts, defect)

Comment 1

[Jose Manuel Cantera]

STR: 

Add a contact with birtday. Export it to SDCArd. Import it. Birthday is lost

Comment 2

[Jose Manuel Cantera]

Attachment: 17803.html

Comment 3

[Francisco Jordano [:arcturus] [:francisco]]

The anniversary is a field for vcard format, 4.0 and we are downgrading from that format to 3.0, since our product team looks for more compatibility with android devices.

Flagging Sergi for needinfo to check if that will conflicts with the current work on on the downgrading process.

Comment 4

[Preeti Raghunath(:Preeti)]

cut and dry blocker

Comment 5

[Sergi Mansilla [:sergi] (Telenor) [PTO]]

Even if we don't export to 4.0, importing should work with the birthday field (we do import vCard 4.0), so the changes in `vcard_parser.js` should get into the tree. I made some comments on Github to the patch as well.

I think the code in contacts2vcard.js should be commented (and not deleted) as a reminder in case we switch back to vCard 4.0 exporting. What do you think?

Comment 6

[Sergi Mansilla [:sergi] (Telenor) [PTO]]

About the date format, we can either parse the anniversary/birthday fields ourselves or let JS' `Date` try to parse and react to it. In any case, I don't think we should abort an import just because one of these fields is not valid.

Comment 7

[Francisco Jordano [:arcturus] [:francisco]]

Comment on attachment 8399294 [details]
17803.html

Please rebase and merge once travis is green.

I've tried this branch by itself.

Thanks!

Comment 8

[Jose Manuel Cantera]

Sergi,

Your comments have been addressed. Please check and provide your f?. I would very grateful if you can do it soon as it is a blocking bug.

thanks!

Comment 9

[Sergi Mansilla [:sergi] (Telenor) [PTO]]

Looks good to me, thanks! f+

Comment 10

[Jose Manuel Cantera]

https://github.com/mozilla-b2g/gaia/commit/4146134abd84fbf0e9052d1091f675fb78f3c2bc

Comment 11

[Ryan VanderMeulen [:RyanVM]]

v1.4: https://github.com/mozilla-b2g/gaia/commit/3906a14ab01450df1f38e47004efc58210e23cc8#diff-1