989927 - [Contacts][Refactor] Create a library that reads the Global Contacts DataStore and provide a single contact

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Contacts, defect)

Description

[Noemí Freire (:noemi)]

Notice that the Global Contacts Datastore will store the merging DataStore information

Comment 1

[Wesley Huang [:wesley_huang] (EPM) (NI me)]

moving to sprint3, as this seems not finished yet.

Comment 2

[Maria Angeles Oteo (:oteo)]

moving to sprint 4

Comment 3

[Jose Manuel Cantera]

Attachment: 20423.html

Comment 4

[Francisco Jordano [:arcturus] [:francisco]]

Comment on attachment 8439059 [details]
20423.html

Hi Sergi,

I'll do the review for this bug, but could be nice if you leave your feedback too.

Thx.

Comment 5

[Francisco Jordano [:arcturus] [:francisco]]

Comment on attachment 8439059 [details]
20423.html

Left some comments in github.

This is an amazing work, I'm sure will land pretty soon next week.

Thanks!

Comment 6

[Jose Manuel Cantera]

Comment on attachment 8439059 [details]
20423.html

comments addressed

Comment 7

[Francisco Jordano [:arcturus] [:francisco]]

Comment on attachment 8439059 [details]
20423.html

Yeah, looking great!

@jmcf do you think you'll have time to record a demo of this (even if it's on using the firefoxos console) for the sprint planing?

Comment 8

[Jose Manuel Cantera]

(In reply to Francisco Jordano [:arcturus] [:francisco] from comment #7)
> Comment on attachment 8439059 [details]
> 20423.html
> 
> Yeah, looking great!
> 
> @jmcf do you think you'll have time to record a demo of this (even if it's
> on using the firefoxos console) for the sprint planing?

of course,

Comment 9

[Jose Manuel Cantera]

https://github.com/mozilla-b2g/gaia/commit/eac13407742a55b11e1877b4df2abdfd22cd582e

Comment 10

[Francisco Jordano [:arcturus] [:francisco]]

(In reply to Jose Manuel Cantera from comment #8)
> 
> of course,


Awesome \o/