989929 - [Contacts][Refactor] Create Contacts indexed DB library to support synchronization from the Global Contacts Datastore

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Contacts, defect)

Description

[Noemí Freire (:noemi)]

The idea is to enhance the velocity for searching and listing

Comment 1

[Francisco Jordano [:arcturus] [:francisco]]

Would like to take a look to this after my rejoin.

Comment 2

[Jose Manuel Cantera]

Attachment: 20613.html

Comment 3

[Francisco Jordano [:arcturus] [:francisco]]

Comment on attachment 8441327 [details]
20613.html

Excellent job here Jose Manuel,

just left some comments and questions in github.

Thanks a lot for this!

Comment 4

[Jose Manuel Cantera]

Comment on attachment 8441327 [details]
20613.html

comments addressed

Comment 5

[Francisco Jordano [:arcturus] [:francisco]]

Code wise all the request has been filled, looking great.

Just have one question, right now we are saving the contact, do we really need to save the whole thing? I know that we will be saving time, but we will be breaking the rule of the data contact is owned by each datastore.

Despite that, how we will handle things like an app has been uninstalled?

Let's sync tomorrow about that.

But as I said, this great work is pretty close to the final thing.

Comment 6

[Francisco Jordano [:arcturus] [:francisco]]

Comment on attachment 8441327 [details]
20613.html

Ben,

I'm flagging you for feedback to have your opinion as performance expert.

This is part of the data refactor that we were talking months ago, with a proper contacts's indexedDB, do you see anything else that we could have left?

Kind of indexes, organization of the DB, etc. I know that you are aware of a lot idb performance tips and would like to know if they could apply here.

Thanks!

Comment 7

[Ben Kelly [:bkelly, not reviewing]]

I'll take a look at this, but will probably be delayed until later in the week or early next week.

Comment 8

[Jose Manuel Cantera]

Comment on attachment 8441327 [details]
20613.html

re.asking for review as it was agreed on Friday to land this and perform a series of follow-ups

Comment 9

[Francisco Jordano [:arcturus] [:francisco]]

Comment on attachment 8441327 [details]
20613.html

As we commented offline, we will land this since doesnt interfeer right now with the current code as a barebone of what we want to achieve.

We opened bug 1031306 to measure the performance of several ideas.

Comment 10

[Jose Manuel Cantera]

https://github.com/jmcanterafonseca/gaia/commit/c586274fcf38811c66847ce5e3307af3965bdd0c

Comment 11

[Ben Kelly [:bkelly, not reviewing]]

Comment on attachment 8441327 [details]
20613.html

Sorry it took me so long to look at this.  Clearing the flag since I only looked briefly as this has already been in the tree for some time.

Overall it looks good to me, but I had a couple comments/questions:

1) Is this intended to be used by other apps or only contacts app?  I seem to recall talking about creating a "data-only contacts app" that provides the shared datastore.  Is this consuming from that datastore or somehow helping to provide it?

2) The comment reference searching, but I don't see a search function.  Ultimately I think we will want to build a full text search database.  Each row would contain a single word and then a list of ids pointing back to the source contact or contact field.