getShortcutOrURIAndPostData should have a synchronous callback behavior

RESOLVED FIXED in Firefox 31

Status

()

Firefox
Location Bar
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: Paolo, Assigned: Paolo)

Tracking

({addon-compat})

Trunk
Firefox 31
addon-compat
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

3 years ago
Internal uses of getShortcutOrURIAndPostData should have a synchronous behavior, thus they should not use Promises or Tasks, to allow the conversion in bug 887923 to proceed.
(Assignee)

Comment 1

3 years ago
Created attachment 8399393 [details] [diff] [review]
The patch

Carrying over r+ from bug 887923.
Attachment #8399393 - Flags: review+
(Assignee)

Comment 2

3 years ago
The tryserver build from the original bug is here:

https://tbpl.mozilla.org/?tree=Try&rev=c8d18a501f2a
Keywords: addon-compat
(Assignee)

Comment 3

3 years ago
https://hg.mozilla.org/integration/fx-team/rev/336c25e3063e
(Assignee)

Comment 4

3 years ago
Add-ons that called the Promise variant will need to switch to the callback-based variant, or use the following technique for Promise compatibility:

new Promise(resolve => getShortcutOrURIAndPostData(query, resolve));
https://hg.mozilla.org/mozilla-central/rev/336c25e3063e
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 31
(Assignee)

Updated

3 years ago
Blocks: 996671
QA Whiteboard: [qa-]
You need to log in before you can comment on or make changes to this bug.