Closed
Bug 989984
Opened 11 years ago
Closed 11 years ago
getShortcutOrURIAndPostData should have a synchronous callback behavior
Categories
(Firefox :: Address Bar, defect)
Firefox
Address Bar
Tracking
()
RESOLVED
FIXED
Firefox 31
People
(Reporter: Paolo, Assigned: Paolo)
References
Details
(Keywords: addon-compat)
Attachments
(1 file)
17.20 KB,
patch
|
Paolo
:
review+
|
Details | Diff | Splinter Review |
Internal uses of getShortcutOrURIAndPostData should have a synchronous behavior, thus they should not use Promises or Tasks, to allow the conversion in bug 887923 to proceed.
Assignee | ||
Comment 1•11 years ago
|
||
Carrying over r+ from bug 887923.
Attachment #8399393 -
Flags: review+
Assignee | ||
Comment 2•11 years ago
|
||
The tryserver build from the original bug is here:
https://tbpl.mozilla.org/?tree=Try&rev=c8d18a501f2a
Keywords: addon-compat
Assignee | ||
Comment 3•11 years ago
|
||
Assignee | ||
Comment 4•11 years ago
|
||
Add-ons that called the Promise variant will need to switch to the callback-based variant, or use the following technique for Promise compatibility:
new Promise(resolve => getShortcutOrURIAndPostData(query, resolve));
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 31
You need to log in
before you can comment on or make changes to this bug.
Description
•