990125 - Duplicate reminders to update apps

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: Web Apps (PWAs), defect, P1)

Description

[Lawrence Mandel [:lmandel] (use needinfo)]

Attachment: Duplicate app update notifications

I'm seeing duplicate reminders to update apps in my notification window. I expect that I should only see one notification at a time.

Comment 1

[Myk Melez [:myk] [@mykmelez]]

There are a couple different possible causes of this, but the one that seems most likely is that the automatic update service is running in each individual app process in addition to the main Fennec process.

We might actually want that in the future, so apps can update themselves if the user doesn't start Fennec.  But that's not how the updater is currently designed to work, so it's a bug for it to work like that today.

Comment 2

[Myk Melez [:myk] [@mykmelez]]

Attachment: patch v1: ignore automatic update checks in webapp processes

Here's the minimal fix.  It adds a pref to enable the automatic webapp update check and disables it on webapp firstrun.

It might be better to remove the declarative WebappsUpdateTimer component registration and instead register the timer programmatically only when running Fennec against the default (non-webapp) profile.

But that's a bigger, riskier change, and I'm looking to minimize risk here to make this a candidate for uplift.  We can always do that later if it makes sense.  And in any case this whole "set a pref on firstrun for the webapp" codepath seems pretty well worn, as is the declarative component registration.  So maybe it's the right thing to do anyway.

Comment 3

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 8405079 [details] [diff] [review]
patch v1: ignore automatic update checks in webapp processes

Someday, we might have a JSM that, among other things, provides an easy way to determine under what context the process is being run: browser, webapp, widget (GeckoView).

This seems workable for now. I suppose, when the time comes, we'd just remove the preference from the code and nothing will be affected.

Comment 4

[Myk Melez [:myk] [@mykmelez]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/afc7a9404a5f

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/afc7a9404a5f

Comment 6

[Myk Melez [:myk] [@mykmelez]]

Comment on attachment 8405079 [details] [diff] [review]
patch v1: ignore automatic update checks in webapp processes

[Approval Request Comment]
Bug caused by (feature/regressing bug #): 
  Bug 934760 and its followups.

User impact if declined:
  Users will receive multiple notifications about updates.

Testing completed (on m-c, etc.): 
  I tested locally, and this landed on Inbound Friday and on Central
  this morning.

Risk to taking this patch (and alternatives if risky): 
  This is a low-risk patch and the minimal fix.

String or IDL/UUID changes made by this patch:
  None.

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/b2ffcc2bdc1e
https://hg.mozilla.org/releases/mozilla-beta/rev/3960907890b7

Comment 8

[Cristina Madaras, QA [:CristinaM]]

Verified as fixed in builds:
- 30.0a2 (2014-04-17);
- 31.0a1 (2014-04-17);
- 29.0b8
Devices: Asus Transformer (Android 4.2.1) and Nexus 4 (Android 4.4.2).