990171 - [Email] Fix NPE in FormNavigation card handling

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::E-Mail, defect)

Comment 1

[Marcus Cavanaugh [:mcav]]

Attachment: Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/17827

Comment 2

[Marcus Cavanaugh [:mcav]]

STR:

1. Set up a new mail account in Firefox Nightly.
2. On the password field, hit "Enter" on your computer's keyboard after typing your password.
3. See an error in the JS console.

Comment 3

[James Burke [:jrburke]]

Comment on attachment 8399585 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/17827

It looks like the event.preventDefault() was added for the changeset in bug 805501. I suppose so that if you press Enter while focused on the Next button it does not trigger the FormNavigation logic?

I can see the case for wanting to be protective for methods that are used for event handlers or non-handler code, but also a case for onLast handlers for FormNavigation to have more context about what event triggered the onLast call, particularly with FormNavigation.onKeyPress passing event to focusNextInput.

So what about just passing in the event to onLast in the FormNavigation instead? You can flip review back to me once we have the final path sorted.

Comment 4

[Marcus Cavanaugh [:mcav]]

Comment on attachment 8399585 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/17827

Sounds reasonable to me.

Comment 5

[Marcus Cavanaugh [:mcav]]

Landed:

https://github.com/mcav/gaia/commit/849a605ed6afae5048f40c94e32222d55dc9d596