990196 - icu tries to use INSTALL_SCRIPT during build

Status: NEW

(Core :: JavaScript: Internationalization API, defect)

Description

[Landry Breuil (:gaston)]

During build of icu within 29.0b3 as regular user, it tries to use INSTALL_SCRIPT (at http://mxr.mozilla.org/mozilla-beta/source/intl/icu/source/Makefile.in#314), which for some reason (the ports build environment is like this) is set to:

../build-amd64/js/src/intl/icu/target/config.log:INSTALL_SCRIPT='install -c -o root -g bin -m 555'

Obviously since i'm building as regular user, this fails with:
install: config/icu-config: chown/chgrp: Operation not permitted

I can workaround this by replacing INSTALL_SCRIPT by a plain install call:

-       $(INSTALL_SCRIPT) $(top_srcdir)/config/icu-config-top $@
+       install -m 555 $(top_srcdir)/config/icu-config-top $@

but that's rather ugly. Since that's coming from upstream i suppose we dont want to patch Makefile.in either...

Comment 1

[Landry Breuil (:gaston)]

I'm only seeing this on beta when building from the source tarball using configure/make within the bsd ports infrastructure, not on aurora/central when building via mach/gmake -f client.mk in my buildbot..

Comment 2

[Landry Breuil (:gaston)]

Mike, any idea how to workaround this build subtile failure ?

Comment 3

[Mike Hommey [:glandium]]

I can't see a reason why this would be a problem on beta/release and not aurora/central, except if your autoconf2.13 creates a configure script very different from the one shipped in our tarballs. If that's the case, then it means your autoconf2.13 has openbsd patches that you'd need in your configure.

Comment 4

[Landry Breuil (:gaston)]

As i said in comment 0, the difference here is that i build beta/release in our packaging infrastructure (ports), which sets INSTALL_SCRIPT (via the environment) to  install -c -o root -g bin -m 555 (which fails to be used as regular user during the build step) while when building aurora/central manually from a src tree, there's no such env var so INSTALL_SCRIPT defaults to INSTALL, ie INSTALL='/usr/bin/install -c' -> no problem as regular user.

While i agree this is a local problem on OpenBSD, and should be discussed upstream, i think the INSTALL* macros should only be used when in an installation target (usually ran as root) and not during a build target. Especially since right after, a chmod is done to u+w.. i dont think itd be a huge issue if INSTALL_SCRIPT would be replaced by 'hardcoding' install -m 555.

Comment 5

[Mike Hommey [:glandium]]

Except that, as you said, this comes from upstream ICU.