990214 - [Inari] gaia-ui-tests do not run on device.

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::UI Tests, defect)

Description

[Yura Zenevich [:yzen] (please use "needinfo")]

When trying to run the gaia ui tests on inari device, the tests just stall (on a black screen before "powered my mozilla technology" screen). When looking at logcat I see the following error message being reprinted constantly:

I/Gecko   ( 1773): 1396296364660	Marionette	INFO	sendToClient: {"from":"0","error":{"message":"Unable to locate element: div.appWindow.active","status":7,"stacktrace":null}}, ...

Modifying cleanup_data function and just leaving the 
self.device.manager.removeDir('/data/b2g/mozilla')
line seemed to fix the issue.

Comment 1

[Yura Zenevich [:yzen] (please use "needinfo")]

Upon further investigation, the tests will work as long as this line in cleanup_data is missing:
self.device.manager.removeDir('/data/local/webapps')

Comment 2

[Dave Hunt [:davehunt] [he/him] ⌚BST]

Is the /data/local/webapps directory present? Are you able to remove it using adb shell rm? Perhaps we need to make this conditional based on its presence, or at least fail fast rather than stall the tests.

Comment 3

[Yura Zenevich [:yzen] (please use "needinfo")]

Yes /data/local/webapps is present and I can remove it with adb shell rm.

Comment 4

[Dave Hunt [:davehunt] [he/him] ⌚BST]

After deleting that using adb, are you able to run the tests unmodified? Perhaps you could experiment a little with the various cleanup calls to see which is causing the stall. Essentially all the removeDir method does is |adb rm -r dir|, see http://hg.mozilla.org/mozilla-central/file/ac6cbaa47f34/testing/mozbase/mozdevice/mozdevice/devicemanagerADB.py#l269

Comment 5

[Zac C (:zac)]

yzen, are you still having problems with this?

If you find a resolution you can file it as a pull request with us to review it and we'll try and get it compatible with Inari.

Comment 6

[Yura Zenevich [:yzen] (please use "needinfo")]

(In reply to Zac C (:zac) from comment #5)
> yzen, are you still having problems with this?
> 
> If you find a resolution you can file it as a pull request with us to review
> it and we'll try and get it compatible with Inari.

I tested it a little more, it looks like what causes the stalling is the webapps.json being removed and replaced with an empty JSON one. Any thoughts, Zac?

Comment 7

[Zac C (:zac)]

Yura, we'll try running the Hamachi tests without removing that file and if it doesn't regress our tests we'll try and remove it permanently.

Comment 8

[Zac C (:zac)]

Attachment: github pr

Yzen, can you run this on your Inari?

I've run it on a Hamachi here:
http://selenium.qa.mtv2.mozilla.com:8080/job/b2g.hamachi.mozilla-central.ui.adhoc/363/

Comment 9

[Yura Zenevich [:yzen] (please use "needinfo")]

Comment on attachment 8414459 [details] [review]
github pr

Tests now work on the device, thanks!

Comment 10

[[:AndreiH]]

So I guess this has been resolved for Inari atm.
Safe to close zac?

Comment 11

[Zac C (:zac)]

Pardon me for not addressing this sooner:
https://github.com/mozilla-b2g/gaia/commit/76378b4f3dc21149529aab3d9a4fc5800c256d98

Comment 12

[Dave Hunt [:davehunt] [he/him] ⌚BST]

Is bug 977046 no longer valid then? I notice that the comments in that bug indicate that removing /data/local/webapps was the main intention of the patch.

Comment 13

[Zac C (:zac)]

(In reply to Dave Hunt (:davehunt) from comment #12)
> Is bug 977046 no longer valid then? I notice that the comments in that bug
> indicate that removing /data/local/webapps was the main intention of the
> patch.

The tests that did prompt that have been stable lately but I'm not sure of the cause and effect. 

But did not realise that removing this folder would cause issues, we don't want that.

Comment 14

[Zac C (:zac)]

btw if this does cause problems for Hamachi I'll back it out because we don't support Inari anymore.