Closed
Bug 990319
Opened 10 years ago
Closed 10 years ago
Stop putting unit tests in minified JS bundle
Categories
(Marketplace Graveyard :: Code Quality, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: cvan, Unassigned)
References
()
Details
(Keywords: perf, Whiteboard: [qa-])
https://marketplace-stage.cdn.mozilla.net/media/fireplace/js/include.js?b=1396040642189 Current size: 318 KB (113 KB gzip'd) 1. Search for 'assert' 2. lol
|
Reporter | |
Comment 1•10 years ago
|
||
Also: 1. Search for 'views/tests' 2. lol
|
|
Reporter | |
Comment 2•10 years ago
|
||
Before: https://marketplace-dev.mozflare.net/media/fireplace/js/include.js?b=1396314540637 Current size: 308 KB (86 KB gzip'd)
|
|
Reporter | |
Comment 3•10 years ago
|
||
Patched commonplace to stop including unit tests: https://github.com/mozilla/commonplace/commit/136cc6e Pushed new version of commonplace: https://github.com/mozilla/commonplace/commit/e05cb41 Bumped fireplace's version of commonplace: https://github.com/mozilla/fireplace/commit/3d32cb5 After: https://marketplace-dev.mozflare.net/media/fireplace/js/include.js?b=1396316007473 Current size: 303 KB (85.809 KB gzip'd)
|
|
Reporter | |
Comment 4•10 years ago
|
||
https://github.com/mozilla/fireplace/commit/14b9fab
You need to log in
before you can comment on or make changes to this bug.
Description
•