Closed Bug 990337 Opened 11 years ago Closed 11 years ago

Remove lightbox ghetto fresh

Categories

(Marketplace Graveyard :: Code Quality, defect, P2)

Product:
Marketplace Graveyard
Component:
Code Quality
Type:
defect

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: cvan, Assigned: spasovski)

References

Details

(Keywords: perf)

https://github.com/mozilla/fireplace/blob/master/hearth/media/js/lightbox.js#L139 The `.product-details` selector doesn't even apply anymore as that class is gone now ... which begs the question: do we still need this code? Davor was the original author of this. Do we, Davor?
No longer blocks: tarako-marketplace
Blocks: 992365
Assignee: nobody → dspasovski
I doubt we need it also especially with the lazy-loading...and it was meant to work around a platform bug. I'll nuketh.
Priority: -- → P2
https://github.com/mozilla/fireplace/compare/36d55e16a9a2...4827571659e2 For QA: Basically just check that app screenshots' lightbox opens and closes as expected.
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.