990384 - Define tabToolbarNavbarOverlap to reduce magic numbers

Status: RESOLVED FIXED

(Firefox :: Theme, defect)

Description

[Matthew N. [:MattN]]

Seperating the tabToolbarNavbarOverlap change out of bug 946987 since bug 990218 also wants it and it's good to do regardless of how bug 946987 ends up.

Comment 1

[Matthew N. [:MattN]]

Attachment: v.1 Replace 1px with @tabToolbarNavbarOverlap@ (and one margin => background-position)

I forget exactly why I switched from margin-bottom to using background-position for bug 946987 but regardless adjusting the background-position makes sense to me.

Comment 2

[Mike Conley (:mconley) (:⚙️)]

Comment on attachment 8399794 [details] [diff] [review]
v.1 Replace 1px with @tabToolbarNavbarOverlap@ (and one margin => background-position)

Review of attachment 8399794 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM - thanks for factoring that stuff out.

Comment 3

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/fx-team/rev/cbae8e109808

Comment 4

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/cbae8e109808

Comment 5

[Matthew N. [:MattN]]

Comment on attachment 8399794 [details] [diff] [review]
v.1 Replace 1px with @tabToolbarNavbarOverlap@ (and one margin => background-position)

[Approval Request Comment]
Bug caused by (feature/regressing bug #): Multiple bugs using hardcoded "1px"
User impact if declined: More fragile UI leading to potential breakages from future changes
Testing completed (on m-c, etc.): m-c
Risk to taking this patch (and alternatives if risky): Low risk mostly swapping hardcoded "1px" for a define
String or IDL/UUID changes made by this patch: None

Comment 6

[Matthew N. [:MattN]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/0ceda75d3c5e
https://hg.mozilla.org/releases/mozilla-beta/rev/a2fccb7d55f7