990390 - [OS X] Cleanup a -moz-any specificity workaround and a comment related to the removal of the add-on bar

Status: NEW

(Firefox :: Theme, defect)

Description

[Matthew N. [:MattN]]

1) There were some !important used below the section "Tabstrip & add-on bar toolbar buttons" to workaround bug 561154. Since the -moz-any were removed from the rules in bug 749804, the workaround is also not necessary and !important are contagious so if it's not necessary it's better not to have it.
2) The comment "Tabstrip & add-on bar toolbar buttons" is now incorrect.

#1 is risky enough that I don't think this should land in 29 and I think it should only land once Australis v.1 is stabilized and we can watch more closely for regressions when less things are changing. Screenshot diffs may help identify unintentional changes.

Comment 1

[Matthew N. [:MattN]]

Attachment: WIP 1 - Untested

We should probably look into more of whether some of the properties that had !important are even necessary.

Comment 2

[Matthew N. [:MattN]]

Comment on attachment 8399806 [details] [diff] [review]
WIP 1 - Untested

Review of attachment 8399806 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/themes/osx/browser.css
@@ +1319,5 @@
>    -moz-margin-end: 1px;
>  }
>  
>  .toolbarbutton-1 > .toolbarbutton-menubutton-button {
> +  -moz-border-end: none !important; /* TODO: remove !important? */

Probably not since the specificity of this was less than "#TabsToolbar .toolbarbutton-1 > .toolbarbutton-menubutton-button" so this was probably for another reason.